git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Claudio Scordino <cloud.of.andor@gmail.com>,
	git@vger.kernel.org, Johannes.Schindelin@gmx.de,
	Sam Vilain <sam.vilain@catalyst.net.nz>
Subject: Re: Hook after pull ?
Date: Wed, 11 Jul 2007 14:26:18 -0700	[thread overview]
Message-ID: <7vk5t63a4l.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 20070711183341.GA2798@steel.home

Alex Riesen <raa.lkml@gmail.com> writes:

> Claudio Scordino, Wed, Jul 11, 2007 17:29:19 +0200:
>> >>If no, does exist any easy way of creating such hook ?
>> >
>> >What for? What do you want to do?
>> >
>> I just need my script to be called after a pull. My script just sends an 
>> email saying that the repository has been pulled (I already did it for the 
>> push).
>
> Ach, on _remote_ repo. Where it is _pulled_from_.
> There are none. You can catch log output of git-daemon, but...
> Isn't it a bit extreme? A fetch (part of a pull) is *very* common
> operation, sometime you'll get a *real* lot of mail.
>
> P.S. BTW, there is no hooks for pull in local (where it is pulled
> into): it is not needed, you already control everything what happens.

I am not sure I am reading this exchange correctly, but I think
Claudio wants to say

	$ git pull repo.or.cz:somebody/project.git/ the-branch 

and have it automatically send e-mail to the somebody (obviously
the hook script needs to have a mapping from the repository to
whom to notify).  As the daemon side cannot tell if the local is
only fetching (and possibly discarding the result) or pulling
(resulting in a merge), I do not think it is reasonable to do
the hooking on the remote side.  It has to be done on the local
if ever.

As you said, the local side has all the control, so in the
strictest sense there is no need for post-* hook, but we do
support a few hooks for local operations, such as post-commit.

(Sam Vilain CC'ed as he wanted to have hooks during and after a
merge).

I suspect that a post merge hook (that also is called in
fast-forward case) would be a good thing to have if people would
want to do this kind of thing often.  The hook most likely wants
to get the ORIG_HEAD and the updated HEAD as parameters, and can
act differently based on the nature of the merge (e.g. was it
fast-forward, was it a merge between the commits made by the
same committer as myself, etc.)

      reply	other threads:[~2007-07-11 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-11 14:41 Hook after pull ? Claudio Scordino
2007-07-11 14:51 ` Alex Riesen
2007-07-11 15:29   ` Claudio Scordino
2007-07-11 18:33     ` Alex Riesen
2007-07-11 21:26       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk5t63a4l.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=cloud.of.andor@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    --cc=sam.vilain@catalyst.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).