From: Junio C Hamano <junkio@cox.net>
To: Rocco Rutte <pdmef@gmx.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Define -D__BSD_VISIBLE for FreeBSD
Date: Thu, 21 Dec 2006 01:26:56 -0800 [thread overview]
Message-ID: <7vk60lbnvj.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11666916581935-git-send-email-pdmef@gmx.net> (Rocco Rutte's message of "Thu, 21 Dec 2006 09:00:58 +0000")
Rocco Rutte <pdmef@gmx.net> writes:
> FreeBSD (6-STABLE) "hides" many declarations (like fchmod(), IPPROTO_IPV6,
> etc.) within '#ifdef __BSD_VISIBLE' blocks. Without this flag, compilation
> will produce lots of warnings and will even fail to compile daemon.c
> since IPPROTO_IPV6 isn't available without it.
I've looked at OpenBSD header files and my impression was that
the symbol __BSD_VISIBLE was pretty much internal to the
implementation, and the programs are not expected to set it
except by defining more public feature macros, such as
_BSD_SOURCE. So I feel a bit uneasy about your approach.
We've changed this exact area quite heavily during the last
24-hours (not in Makefile but in git-compat-util.h). Do you
see the problem with the latest 'master'?
next prev parent reply other threads:[~2006-12-21 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 9:00 [PATCH] Define -D__BSD_VISIBLE for FreeBSD Rocco Rutte
2006-12-21 9:26 ` Junio C Hamano [this message]
2006-12-21 10:09 ` Rocco Rutte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk60lbnvj.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=pdmef@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox