From: Junio C Hamano <junkio@cox.net>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2
Date: Tue, 10 Oct 2006 21:45:36 -0700 [thread overview]
Message-ID: <7vk637xxxr.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20061011020903.63831.qmail@web31812.mail.mud.yahoo.com> (Luben Tuikov's message of "Tue, 10 Oct 2006 19:09:03 -0700 (PDT)")
Luben Tuikov <ltuikov@yahoo.com> writes:
> Commit eeef88cd2 introduced $group_size which
> inverted the meaning of $current_color.
>
> Normally we start with white (same as background) color
> for the zebra coloring, and flip to dark shade only when
> another commit changed some lines of the file. (Thus
> if there are no changes, the file appears black on white.)
I do not have much preference either way, but it was done more
or less deliberately to match what you did with 6dd36ac.
next prev parent reply other threads:[~2006-10-11 4:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 2:09 [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2 Luben Tuikov
2006-10-11 4:45 ` Junio C Hamano [this message]
2006-10-11 7:21 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk637xxxr.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox