From: Junio C Hamano <junkio@cox.net>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] handle concurrent pruning of packed objects
Date: Fri, 02 Jun 2006 09:10:24 -0700 [thread overview]
Message-ID: <7vk67zbksv.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060602160456.GA8957@coredump.intra.peff.net> (Jeff King's message of "Fri, 2 Jun 2006 12:04:56 -0400")
Jeff King <peff@peff.net> writes:
> That shouldn't make a difference for correctness, even if the old packs
> are still there. If you have an object in two packs, then it doesn't
> matter which one you pull it from. The main impacts I can think of are:
> 1. The old pack may already be mapped, and it would be more efficient
> to use it. However, the new pack will be mapped on first use, so it
> will be used from then on.
> 2. The pack list can grow without bound. However, for this to matter,
> you'd have to do many prunes during the course of a single git
> command.
I agree 100% on "shouldn't" part. What I wonder is if everybody
works correctly if we mmap the same file (all available .idx are
mapped all the time, and we map .pack LRU) twice. But I realize
we have NO_MMAP configuration for unfortunate platforms to work
it around so that wouldn't be a big deal.
next prev parent reply other threads:[~2006-06-02 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-02 15:32 [PATCH] handle concurrent pruning of packed objects Jeff King
2006-06-02 15:53 ` Junio C Hamano
2006-06-02 16:03 ` Junio C Hamano
2006-06-02 16:04 ` Jeff King
2006-06-02 16:10 ` Junio C Hamano [this message]
2006-06-02 16:49 ` [PATCH] sha1_file: avoid re-preparing duplicate packs Jeff King
2006-06-02 17:47 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2006-05-30 15:56 [PATCH] handle concurrent pruning of packed objects Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk67zbksv.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox