git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: cel@citi.umich.edu, torvalds@osdl.org
Cc: git@vger.kernel.org
Subject: Re: Am I doing something wrong?
Date: Wed, 21 Dec 2005 13:13:33 -0800	[thread overview]
Message-ID: <7vk6dy5f2a.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <43A9C33E.2070807@citi.umich.edu> (Chuck Lever's message of "Wed, 21 Dec 2005 16:03:58 -0500")

Chuck Lever <cel@citi.umich.edu> writes:

> maybe the Linux kernel repository needs the same treatment.  i'm getting 
> the "all zeros" commit error message when trying to pull from it.

Indeed.

Linus, sorry about bothering you, but could you do the same
band-aid for now and also apply the attached to your
server-info.c, please?

> Junio C Hamano wrote:
>>
>> As a band-aid, I just ran this command at the server that public
>> ones mirror from:
>>
>> 	$ echo >>objects/info/packs
>>

GIT 1.0.0a needs to follow soonish X-<.

-- >8 --
[PATCH] objects/info/packs: work around bug in http-fetch.c::fetch_indices()

The code to fetch pack index files in deployed clients have a
bug that causes it to ignore the pack file on the last line of
objects/info/packs file, so append an empty line to work it
around.

Signed-off-by: Junio C Hamano <junkio@cox.net>

---

 server-info.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

21b1aced83195af50fd8bc9a88e7734c8ee77c0e
diff --git a/server-info.c b/server-info.c
index df19e49..6089765 100644
--- a/server-info.c
+++ b/server-info.c
@@ -200,6 +200,7 @@ static void write_pack_info_file(FILE *f
 	int i;
 	for (i = 0; i < num_pack; i++)
 		fprintf(fp, "P %s\n", info[i]->p->pack_name + objdirlen + 6);
+	fputc('\n', fp);
 }
 
 static int update_info_packs(int force)
-- 
1.0.0

      reply	other threads:[~2005-12-21 21:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-21 16:51 Am I doing something wrong? Randal L. Schwartz
2005-12-21 17:52 ` Junio C Hamano
2005-12-21 17:54   ` Randal L. Schwartz
2005-12-21 18:07     ` Junio C Hamano
2005-12-21 18:17       ` Randal L. Schwartz
2005-12-21 18:27         ` Junio C Hamano
2005-12-21 18:37           ` Peter Baumann
2005-12-21 18:53             ` Peter Baumann
2005-12-21 19:58           ` Junio C Hamano
2005-12-21 21:03             ` Chuck Lever
2005-12-21 21:13               ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk6dy5f2a.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=cel@citi.umich.edu \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).