From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@suse.cz>, Nick Hengeveld <nickh@reactrix.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix bunch of fd leaks in http-fetch
Date: Fri, 11 Nov 2005 21:45:30 -0800 [thread overview]
Message-ID: <7vk6feiflx.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20051111235516.GY30496@pasky.or.cz> (Petr Baudis's message of "Sat, 12 Nov 2005 00:55:16 +0100")
Petr Baudis <pasky@suse.cz> writes:
> The current http-fetch is rather careless about fd leakage, causing
> problems while fetching large repositories. This patch does not reserve
> exhaustiveness, but I covered everything I spotted...
Thanks. While I am sure a quick fix is better for the end user
than not doing anything at all, I am a bit reluctant.
It strikes me somewhat odd that these close() are not tied to
the lifetime rule of the transfer_request structure. When the
program falls back from an individual object to alternates, the
same request structure is reused, but in that case ->local stays
the same. Otherwise, the original request structure is released
so I wonder if would make things cleaner to close ->local inside
request_release()...
Nick?
next prev parent reply other threads:[~2005-11-12 5:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-11 22:58 file descriptor leak? or expected behavior? Becky Bruce
2005-11-11 23:22 ` Becky Bruce
2005-11-11 23:55 ` [PATCH] Fix bunch of fd leaks in http-fetch Petr Baudis
2005-11-12 5:45 ` Junio C Hamano [this message]
2005-11-12 17:38 ` Nick Hengeveld
2005-11-12 19:55 ` Petr Baudis
2005-11-13 3:37 ` Nick Hengeveld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk6feiflx.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=nickh@reactrix.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).