Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix git-verify-tag for local tags
Date: Sun, 09 Oct 2005 12:29:43 -0700	[thread overview]
Message-ID: <7vk6gmebfc.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20051009181246.17885.81654.stgit@zion.home.lan> (Paolo Giarrusso's message of "Sun, 09 Oct 2005 20:12:47 +0200")

Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> writes:

> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
>
> It currently exits printing "git-cat-file SHA1: bad file", while instead we must
> just abort the verification for local tags (i.e. referring to commit objects).

Good spotting, but checking for type being not a tag (not
limited to commit object) would be a better approach.  I'll fix
it up that way and apply (no need to resend).  Thanks.

      parent reply	other threads:[~2005-10-09 19:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-09 18:12 [PATCH 1/2] Fix git-verify-tag for local tags Paolo 'Blaisorblade' Giarrusso
2005-10-09 18:12 ` [PATCH 2/2] git-verify-tag: detect wrong syntax Paolo 'Blaisorblade' Giarrusso
2005-10-09 19:29 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk6gmebfc.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox