* [PATCH] remote-bzr: fix cloning of non-listable repos
@ 2013-05-16 10:04 Felipe Contreras
2013-05-16 16:29 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Felipe Contreras @ 2013-05-16 10:04 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Felipe Contreras
Commit 95b0c60 (remote-bzr: add support for bzr repos) introduced a
regression by assuming all bzr remote repos are listable, but they are
not.
If they are not listable they are basically useless, so let's assume
there is no bzr repo.
Reported-by: Thorsten Kranzkowski <dl8bcu@dl8bcu.de>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
We want this on master for v1.8.3.
contrib/remote-helpers/git-remote-bzr | 3 +++
1 file changed, 3 insertions(+)
diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index b295dd4..ad42317 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -840,6 +840,9 @@ def get_repo(url, alias):
try:
repo = origin.open_repository()
+ if not repo.user_transport.listable():
+ # this repository is not usable for us
+ raise bzrlib.errors.NoRepositoryPresent(repo.bzrdir)
except bzrlib.errors.NoRepositoryPresent:
# branch
--
1.8.3.rc2.542.g24820ba
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] remote-bzr: fix cloning of non-listable repos
2013-05-16 10:04 [PATCH] remote-bzr: fix cloning of non-listable repos Felipe Contreras
@ 2013-05-16 16:29 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2013-05-16 16:29 UTC (permalink / raw)
To: Felipe Contreras; +Cc: git
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Commit 95b0c60 (remote-bzr: add support for bzr repos) introduced a
> regression by assuming all bzr remote repos are listable, but they are
> not.
>
> If they are not listable they are basically useless, so let's assume
> there is no bzr repo.
>
> Reported-by: Thorsten Kranzkowski <dl8bcu@dl8bcu.de>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>
> We want this on master for v1.8.3.
Sure.
>
> contrib/remote-helpers/git-remote-bzr | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
> index b295dd4..ad42317 100755
> --- a/contrib/remote-helpers/git-remote-bzr
> +++ b/contrib/remote-helpers/git-remote-bzr
> @@ -840,6 +840,9 @@ def get_repo(url, alias):
>
> try:
> repo = origin.open_repository()
> + if not repo.user_transport.listable():
> + # this repository is not usable for us
> + raise bzrlib.errors.NoRepositoryPresent(repo.bzrdir)
> except bzrlib.errors.NoRepositoryPresent:
> # branch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-16 16:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-16 10:04 [PATCH] remote-bzr: fix cloning of non-listable repos Felipe Contreras
2013-05-16 16:29 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).