Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile

[Junio C Hamano <gitster@pobox.com>]

"Joachim Schmitz" <jojo@schmitz-digital.de> writes:

> Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index ac49320..03e245a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -90,6 +90,8 @@ all::
>  #
>  # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
>  #
> +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
> +#
>  # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
>  #
>  # Define NO_STRTOK_R if you don't have strtok_r in the C library.

Not really.  "make MKDIR_WO_TRAILING_SLASH=YesPlease" won't do
anything.

You would need at least something like this, no?

 Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git c/Makefile w/Makefile
index 66e8216..21b4816 100644
--- c/Makefile
+++ w/Makefile
@@ -90,6 +90,8 @@ all::
 #
 # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
 #
+# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
+#
 # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
 #
 # Define NO_STRTOK_R if you don't have strtok_r in the C library.
@@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP
 	COMPAT_CFLAGS += -DNO_MKDTEMP
 	COMPAT_OBJS += compat/mkdtemp.o
 endif
+ifdef MKDIR_WO_TRAILING_SLASH
+	COMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH
+endif
 ifdef NO_MKSTEMPS
 	COMPAT_CFLAGS += -DNO_MKSTEMPS
 endif