* [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
@ 2012-09-07 12:10 Joachim Schmitz
2012-09-07 17:27 ` Junio C Hamano
2012-09-07 17:29 ` Junio C Hamano
0 siblings, 2 replies; 5+ messages in thread
From: Joachim Schmitz @ 2012-09-07 12:10 UTC (permalink / raw)
To: 'Junio C Hamano'; +Cc: git
Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
---
Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index ac49320..03e245a 100644
--- a/Makefile
+++ b/Makefile
@@ -90,6 +90,8 @@ all::
#
# Define NO_MKDTEMP if you don't have mkdtemp in the C library.
#
+# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
+#
# Define NO_MKSTEMPS if you don't have mkstemps in the C library.
#
# Define NO_STRTOK_R if you don't have strtok_r in the C library.
--
1.7.12
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
2012-09-07 12:10 [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile Joachim Schmitz
@ 2012-09-07 17:27 ` Junio C Hamano
2012-09-07 17:29 ` Junio C Hamano
1 sibling, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2012-09-07 17:27 UTC (permalink / raw)
To: Joachim Schmitz; +Cc: git
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
2012-09-07 12:10 [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile Joachim Schmitz
2012-09-07 17:27 ` Junio C Hamano
@ 2012-09-07 17:29 ` Junio C Hamano
2012-09-07 18:28 ` Joachim Schmitz
2012-09-08 15:23 ` Joachim Schmitz
1 sibling, 2 replies; 5+ messages in thread
From: Junio C Hamano @ 2012-09-07 17:29 UTC (permalink / raw)
To: Joachim Schmitz; +Cc: git
"Joachim Schmitz" <jojo@schmitz-digital.de> writes:
> Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
> ---
> Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index ac49320..03e245a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -90,6 +90,8 @@ all::
> #
> # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
> #
> +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
> +#
> # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
> #
> # Define NO_STRTOK_R if you don't have strtok_r in the C library.
Not really. "make MKDIR_WO_TRAILING_SLASH=YesPlease" won't do
anything.
You would need at least something like this, no?
Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git c/Makefile w/Makefile
index 66e8216..21b4816 100644
--- c/Makefile
+++ w/Makefile
@@ -90,6 +90,8 @@ all::
#
# Define NO_MKDTEMP if you don't have mkdtemp in the C library.
#
+# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
+#
# Define NO_MKSTEMPS if you don't have mkstemps in the C library.
#
# Define NO_STRTOK_R if you don't have strtok_r in the C library.
@@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP
COMPAT_CFLAGS += -DNO_MKDTEMP
COMPAT_OBJS += compat/mkdtemp.o
endif
+ifdef MKDIR_WO_TRAILING_SLASH
+ COMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH
+endif
ifdef NO_MKSTEMPS
COMPAT_CFLAGS += -DNO_MKSTEMPS
endif
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
2012-09-07 17:29 ` Junio C Hamano
@ 2012-09-07 18:28 ` Joachim Schmitz
2012-09-08 15:23 ` Joachim Schmitz
1 sibling, 0 replies; 5+ messages in thread
From: Joachim Schmitz @ 2012-09-07 18:28 UTC (permalink / raw)
To: 'Junio C Hamano'; +Cc: git
> -----Original Message-----
> From: Junio C Hamano [mailto:gitster@pobox.com]
> Sent: Friday, September 07, 2012 7:30 PM
> To: Joachim Schmitz
> Cc: git@vger.kernel.org
> Subject: Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
>
> "Joachim Schmitz" <jojo@schmitz-digital.de> writes:
>
> > Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
> > ---
> > Makefile | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index ac49320..03e245a 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -90,6 +90,8 @@ all::
> > #
> > # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
> > #
> > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
> > +#
> > # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
> > #
> > # Define NO_STRTOK_R if you don't have strtok_r in the C library.
>
> Not really. "make MKDIR_WO_TRAILING_SLASH=YesPlease" won't do
> anything.
>
> You would need at least something like this, no?
>
Yes, that is better, thanks
> Makefile | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git c/Makefile w/Makefile
> index 66e8216..21b4816 100644
> --- c/Makefile
> +++ w/Makefile
> @@ -90,6 +90,8 @@ all::
> #
> # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
> #
> +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
> +#
> # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
> #
> # Define NO_STRTOK_R if you don't have strtok_r in the C library.
> @@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP
> COMPAT_CFLAGS += -DNO_MKDTEMP
> COMPAT_OBJS += compat/mkdtemp.o
> endif
> +ifdef MKDIR_WO_TRAILING_SLASH
> + COMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH
> +endif
> ifdef NO_MKSTEMPS
> COMPAT_CFLAGS += -DNO_MKSTEMPS
> endif
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
2012-09-07 17:29 ` Junio C Hamano
2012-09-07 18:28 ` Joachim Schmitz
@ 2012-09-08 15:23 ` Joachim Schmitz
1 sibling, 0 replies; 5+ messages in thread
From: Joachim Schmitz @ 2012-09-08 15:23 UTC (permalink / raw)
To: 'Junio C Hamano'; +Cc: git
> From: Joachim Schmitz [mailto:jojo@schmitz-digital.de]
> Sent: Friday, September 07, 2012 8:28 PM
> To: 'Junio C Hamano'
> Cc: 'git@vger.kernel.org'
> Subject: RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
>
>
>
> > -----Original Message-----
> > From: Junio C Hamano [mailto:gitster@pobox.com]
> > Sent: Friday, September 07, 2012 7:30 PM
> > To: Joachim Schmitz
> > Cc: git@vger.kernel.org
> > Subject: Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile
> >
> > "Joachim Schmitz" <jojo@schmitz-digital.de> writes:
> >
> > > Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
> > > ---
> > > Makefile | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index ac49320..03e245a 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -90,6 +90,8 @@ all::
> > > #
> > > # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
> > > #
> > > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
> > > +#
> > > # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
> > > #
> > > # Define NO_STRTOK_R if you don't have strtok_r in the C library.
> >
> > Not really. "make MKDIR_WO_TRAILING_SLASH=YesPlease" won't do
> > anything.
> >
> > You would need at least something like this, no?
> >
>
> Yes, that is better, thanks
There's something missing though, to make it fully usable, see below
>
> > Makefile | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git c/Makefile w/Makefile
> > index 66e8216..21b4816 100644
> > --- c/Makefile
> > +++ w/Makefile
> > @@ -90,6 +90,8 @@ all::
> > #
> > # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
> > #
> > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
> > +#
> > # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
> > #
> > # Define NO_STRTOK_R if you don't have strtok_r in the C library.
> > @@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP
> > COMPAT_CFLAGS += -DNO_MKDTEMP
> > COMPAT_OBJS += compat/mkdtemp.o
> > endif
> > +ifdef MKDIR_WO_TRAILING_SLASH
> > + COMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH
+ COMPAT_OBJS += compat/mkdir.o
> > +endif
> > ifdef NO_MKSTEMPS
> > COMPAT_CFLAGS += -DNO_MKSTEMPS
> > endif
Bye, Jojo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-09-08 15:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-07 12:10 [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile Joachim Schmitz
2012-09-07 17:27 ` Junio C Hamano
2012-09-07 17:29 ` Junio C Hamano
2012-09-07 18:28 ` Joachim Schmitz
2012-09-08 15:23 ` Joachim Schmitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).