From: Junio C Hamano <gitster@pobox.com>
To: 김남형 <namhyung.kim@lge.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] ctype: implement islower/isupper macro
Date: Thu, 09 Feb 2012 20:03:30 -0800 [thread overview]
Message-ID: <7vliobs5bh.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4F3481CD.5010303@lge.com> ("김남형"'s message of "Fri, 10 Feb 2012 11:32:45 +0900")
김남형 <namhyung.kim@lge.com> writes:
> 2012-02-10 11:17 AM, Junio C Hamano wrote:
>> Namhyung Kim <namhyung.kim@lge.com> writes:
>>
>>> The git-compat-util.h provides various ctype macros but lacks those two
>>> (along with others). Add them.
>>
>> Isn't that because we do not use them ourselves? Uses in compat/ do not
>> count, and judging from the way it is used in compat/fnmatch/fnmatch.c,
>> the implementation of sane_iscase() might be overly protective.
>>
>> What problem are you trying to solve?
>
> There's no problem. In fact, these patches come from perf as it uses a
> copy of git code in this part.
Kim-ssi, the above is something I would have like to see in your first
message.
> If you don't
> think it's worth applying I'm fine with dropping it.
I never said these patches are worthless.
I just was wondering what the motivation behind them were. If you are
involved in maintaining Perf, and if it wants to keep its own forked copy
as close as ours, that is a good enough justification, as long as the
additions we do not use ourselves is still reasonably done.
next prev parent reply other threads:[~2012-02-10 4:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 2:13 [PATCH 1/2] ctype.c only wants git-compat-util.h Namhyung Kim
2012-02-10 2:13 ` [PATCH 2/2] ctype: implement islower/isupper macro Namhyung Kim
2012-02-10 2:17 ` Junio C Hamano
2012-02-10 2:32 ` 김남형
2012-02-10 4:03 ` Junio C Hamano [this message]
2012-02-10 5:04 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vliobs5bh.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).