From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] make-static: master
Date: Wed, 14 Sep 2011 12:03:36 -0700 [thread overview]
Message-ID: <7vlitrt08n.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4E704EA2.8060307@viscovery.net> (Johannes Sixt's message of "Wed, 14 Sep 2011 08:50:10 +0200")
Johannes Sixt <j.sixt@viscovery.net> writes:
> Am 9/14/2011 1:46, schrieb Junio C Hamano:
>> This kind of breakage report was exactly what I was looking for by
>> merging it early to 'next'. Hopefully no other (function / platform) combo
>> has such dependencies...
>
> There is! prepare_git_cmd is used from the Windows section in run-command.c.
> Therefore, the following hunks of the patch should be reverted.
Sorry, I do not think it should just be "reverted".
Instead, a new comment should be added to explain why it needs to be
exposed, which was the _whole_ point of the message you are replying to,
in which I showed how it should be done by an example.
next prev parent reply other threads:[~2011-09-14 19:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-11 19:38 [PATCH 1/3] sparse: Fix some "symbol not declared" warnings Ramsay Jones
2011-09-11 21:38 ` Junio C Hamano
2011-09-12 0:06 ` Junio C Hamano
2011-09-11 21:38 ` [PATCH 1/3] make-static: master Junio C Hamano
2011-09-12 6:14 ` Ramkumar Ramachandra
2011-09-15 4:29 ` Junio C Hamano
2011-09-13 22:51 ` Ramsay Jones
2011-09-13 23:46 ` Junio C Hamano
2011-09-14 6:50 ` Johannes Sixt
2011-09-14 19:03 ` Junio C Hamano [this message]
2011-09-14 20:33 ` Junio C Hamano
2011-09-14 8:52 ` Thomas Rast
2011-09-11 21:38 ` [PATCH 2/3] make-static: next Junio C Hamano
2011-09-11 21:38 ` [PATCH 3/3] make-static: pu Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlitrt08n.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).