From: Junio C Hamano <gitster@pobox.com>
To: "Henrik Grubbström" <grubba@grubba.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] convert: Safer handling of $Id$ contraction.
Date: Tue, 02 Mar 2010 17:10:57 -0800 [thread overview]
Message-ID: <7vljeamcpq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1267460218-1172-1-git-send-email-grubba@grubba.org
Henrik Grubbström <grubba@grubba.org> writes:
> From: Henrik Grubbström (Grubba) <grubba@grubba.org>
You can omit this line, as it is the same as your From: header.
> The code to contract $Id:xxxxx$ strings could eat an arbitrary amount
> of source text if the terminating $ was lost. It now refuses to
> contract $Id:xxxxx$ strings spanning multiple lines.
Hmm, at least when going from working tree to the index, shouldn't the
code refuse _and_ die(), instead of silently pass the garbage through?
next prev parent reply other threads:[~2010-03-03 1:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 16:16 [PATCH 1/4] convert: Safer handling of $Id$ contraction Henrik Grubbström
2010-03-01 16:16 ` [PATCH 2/4] convert: Keep foreign $Id$ on checkout Henrik Grubbström
2010-03-01 16:16 ` [PATCH 3/4] convert: Inhibit contraction of foreign $Id$ during stats Henrik Grubbström
2010-03-01 16:16 ` [PATCH 4/4] convert: Added core.refilteronadd feature Henrik Grubbström
2010-03-03 1:11 ` [PATCH 2/4] convert: Keep foreign $Id$ on checkout Junio C Hamano
2010-03-03 11:36 ` Henrik Grubbström
2010-03-03 1:10 ` Junio C Hamano [this message]
2010-03-03 10:40 ` [PATCH 1/4] convert: Safer handling of $Id$ contraction Henrik Grubbström
2010-03-09 9:22 ` Henrik Grubbström
-- strict thread matches above, loose matches on Subject: below --
2010-03-15 15:30 [PATCH 0/4] ident attribute related patches (resend w/ testsuite) Henrik Grubbström (Grubba)
2010-03-15 15:30 ` [PATCH 1/4] convert: Safer handling of $Id$ contraction Henrik Grubbström (Grubba)
2010-03-15 15:39 ` Bert Wesarg
2010-03-15 18:21 ` Henrik Grubbström
2010-03-15 18:16 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljeamcpq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=grubba@grubba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).