git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: bill lam <cbill.lam@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: unmerged files listed in the beginning of git-status
Date: Tue, 01 Sep 2009 09:42:25 -0700	[thread overview]
Message-ID: <7vljkypqfi.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090901145213.GB4194@debian.b2j> (bill lam's message of "Tue\, 1 Sep 2009 22\:52\:13 +0800")

bill lam <cbill.lam@gmail.com> writes:

> I noticed in the new git 1.6.4.2 .

I hope you didn't.  This is only in 'master' and will appear first in the
upcoming 1.6.5; it is never meant for 1.6.4.X maintenance series and
1.6.4.2 does not have this change.

> git-status show unmerged files
> with a clause of explanation.  This is very helpful. However these
> unmerged files are listed in the beginning and followed by modified
> files,

"git status" is preview of what git commit does.  The "Changes to be
committed" section is given at the beginning of the output because it is
the most important one.  But while reviewing the conflicts, you would want
to notice conflicted paths more than what are already resolved and staged.

It used to be that unmerged paths were mixed together with locally
modified paths in the "Changed but not updated" list, after the "Changes
to be committed" list.  This made the unmerged paths harder to spot than
necessary.

To remedy this, unmerged ones are now:

 (1) placed in a new, separate section that appears only when there are
     unmerged paths, to make the fact that there is something unusual
     going on (i.e. conflicts) stand out; and

 (2) the new section is given at the top of the status output to give
     these unmerged paths more prominence.

Having said all that, the relative importance of the pieces of information
given in "git status" output is fairly subjective.

If you are a confident, know-what-I-am-doing type, you would see the
"Changes to be committed" list the most important, because that is where
you make sure you have added all the changes you want to include in the
commit.  If you are a forgetful type, on the other hand, you would see
"Changed but not updated" and "Untracked files" more important, because
that is where you make sure there isn't any files you modified and new
files you created that you want to include in the commit but may have
forgotten.  If you are into flipping many branches and often commit your
changes on a wrong branch, you may value the "On branch foo" information
at the top the most.  So in that sense, there cannot be a single right
order of these sections.

But unmerged entries are something you need to deal with _first_ before
being able to go further, so in that sense it is more important than
anything else in the traditional output.

In the output, "the most important part first" rule is unlikely to change,
if only because this is what you are shown when committing in the editor,
and even in 1.7.0 when "git status" stops being "git commit --dry-run"
because we would still keep consistency of the two outputs,

By the way, please do not deflect responses to your message away from
yourself using Mail-Followup-To.

  reply	other threads:[~2009-09-01 16:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-01 14:52 unmerged files listed in the beginning of git-status bill lam
2009-09-01 16:42 ` Junio C Hamano [this message]
2009-09-01 19:40   ` Johannes Sixt
2009-09-01 20:13     ` [PATCH] status: list unmerged files after staged files Johannes Sixt
2009-09-01 20:38       ` Junio C Hamano
2009-09-01 21:25         ` [PATCH v2] status: list unmerged files last Johannes Sixt
2009-09-02  0:18           ` Junio C Hamano
2009-09-02  0:39             ` bill lam
2009-09-02  1:15             ` Jeff King
2009-09-02  4:26               ` Junio C Hamano
2009-09-02  5:12                 ` Jeff King
2009-09-02  5:26                   ` Junio C Hamano
2009-09-02  5:28                     ` Jeff King
2009-09-02 10:07                     ` David Aguilar
2009-09-02 17:59                       ` Jeff King
2009-09-03  1:12                         ` David Aguilar
2009-09-05  6:28                           ` Jeff King
2009-09-05  8:48                             ` Jeff King
2009-09-05  8:50                               ` [PATCH/RFC 1/6] status: typo fix in usage Jeff King
2009-09-05  8:52                               ` [PATCH/RFC 2/6] docs: note that status configuration affects only long format Jeff King
2009-09-06  8:04                                 ` Junio C Hamano
2009-09-05  8:53                               ` [PATCH/RFC 3/6] status: refactor short-mode printing to its own function Jeff King
2009-09-06  8:05                                 ` Junio C Hamano
2009-09-05  8:54                               ` [PATCH/RFC 4/6] status: refactor format option parsing Jeff King
2009-09-05  8:55                               ` [PATCH/RFC 5/6] status: add --porcelain output format Jeff King
2009-09-05  8:59                               ` [PATCH/RFC 6/6] commit: support alternate status formats Jeff King
2009-09-05  9:08                               ` [PATCH v2] status: list unmerged files last Jeff King
2009-09-02 19:19                       ` Johannes Sixt
2009-09-02 12:48                   ` Mark Brown
2009-09-02 18:00                     ` Jeff King
2009-09-02 18:39                       ` Mark Brown
2009-09-05  9:04                         ` Jeff King
2009-09-05 11:39                           ` Mark Brown
2009-09-02  9:04     ` unmerged files listed in the beginning of git-status bill lam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vljkypqfi.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=cbill.lam@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).