git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: P Baker <me@retrodict.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Clarify the gitmodules and submodules docs
Date: Wed, 08 Apr 2009 00:16:10 -0700	[thread overview]
Message-ID: <7vljqbpqdh.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <526944450904080004r1249d1b8j4a44472d72502b9c@mail.gmail.com> (P. Baker's message of "Wed, 8 Apr 2009 03:04:46 -0400")

I think the new description is good, and the message claims to be sent by
send-email, but I am seeing a funny whitespace damage everywhere in your
patch.

 * Signed-off-by: and the three-dash lines have a leading SP

 * The first line of diffstat is indented by one SP as expected; the
   second line has one extra SP at the beginning.

 * everything after that has one extra SP at the beginning.  Also the hunk
   header for the first hunk is linewrapped.

Very curious.  I could just hand munge the patch if I wanted to, but I'd
rather not.  As you are in "GSoC preparation", I expect to receive
patches, perhaps tons of them, from you in the future, and I'd want to see
easier procedural wrinkles straightened out first.  That will allow us to
concentrate on the substance when "the real thing" starts.

    Added some explanation to the docs to clear up some confusing parts of
    git-submodules that appeared frequently on the mailing list.

We tend to say "Add some explanation..." here.  Think of it as your giving
an order to _me_, "cause this to happen", by accepting and applying your
patch.

  reply	other threads:[~2009-04-08  7:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1239172816-38966-1-git-send-email-pbaker@retrodict.com>
2009-04-08  7:04 ` [PATCH 1/2] Clarify the gitmodules and submodules docs P Baker
2009-04-08  7:16   ` Junio C Hamano [this message]
2009-04-08 15:33 pbaker
2009-04-08 15:45 ` P Baker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vljqbpqdh.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@retrodict.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).