From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/8] config: Cleanup config file handling.
Date: Sun, 15 Feb 2009 17:15:50 -0800 [thread overview]
Message-ID: <7vljs7gp15.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1234688460-9248-2-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Sun, 15 Feb 2009 11:00:54 +0200")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> As suggested by Johannes Schindelin.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Dscho won't be the only person who will read "git log" output. What was
suggested, what convinced you it is a good idea, what goodness would this
patch add if I take it?
> - if (git_config(show_all_config, NULL) < 0 &&
> - file && errno)
> - die("unable to read config file %s: %s", file,
> - strerror(errno));
> + if (git_config(show_all_config, NULL) < 0)
> + die("error processing config file(s)");
> return 0;
This is the only change with substance in this patch. What difference
does it make? Earlier we failed to say "die" with message in some
situations, and now we die when git_config() signals any error.
What are the situations in whoich the command misbehaved? The commit log
message is where you are expected to explain that.
prev parent reply other threads:[~2009-02-16 1:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 9:00 [PATCH 1/8] config: Trivial rename in preparation for parseopt Felipe Contreras
2009-02-15 9:00 ` [PATCH 2/8] config: Cleanup config file handling Felipe Contreras
2009-02-15 9:00 ` [PATCH 3/8] config: Use parseopt Felipe Contreras
2009-02-15 9:00 ` [PATCH 4/8] config: Improve variable 'type' handling Felipe Contreras
2009-02-15 9:00 ` [PATCH 5/8] config: Disallow multiple config file locations Felipe Contreras
2009-02-15 9:00 ` [PATCH 6/8] config: Don't allow extra arguments for -e or -l Felipe Contreras
2009-02-15 9:00 ` [PATCH 7/8] config: Don't return negative exit codes Felipe Contreras
2009-02-15 9:01 ` [PATCH 8/8] config: Codestyle cleanups Felipe Contreras
2009-02-15 12:22 ` [PATCH 7/8] config: Don't return negative exit codes Johannes Schindelin
2009-02-15 12:39 ` Felipe Contreras
2009-02-15 13:30 ` Felipe Contreras
2009-02-15 12:26 ` [PATCH 5/8] config: Disallow multiple config file locations Johannes Schindelin
2009-02-15 12:44 ` Felipe Contreras
2009-02-15 13:35 ` Felipe Contreras
2009-02-15 12:24 ` [PATCH 4/8] config: Improve variable 'type' handling Johannes Schindelin
2009-02-15 12:43 ` Felipe Contreras
2009-02-15 13:34 ` Felipe Contreras
2009-02-15 20:15 ` [PATCH 2/8] config: Cleanup config file handling Jeff King
2009-02-16 1:15 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljs7gp15.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).