From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Jeff King <peff@peff.net>, Suraj Kurapati <sunaku@gmail.com>,
git@vger.kernel.org
Subject: Re: [Illustration PATCH] add -i: accept single-keypress input
Date: Tue, 03 Feb 2009 21:10:17 -0800 [thread overview]
Message-ID: <7vljsm9492.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 200902031035.04978.trast@student.ethz.ch
Thomas Rast <trast@student.ethz.ch> writes:
> Junio C Hamano wrote:
>
>> Hmm, you could trigger the action immediately after seeing _enough_ number
>> of characters to disambiguate instead of stop-and-prompt, I guess? That
>> way, you would get a single-key merely as a degenerate case when the
>> choices are all distinct.
>
> I don't think that's very nice. On the one hand, you'd really want to
> allow the user to delete some of the input again if he decides to do
> something else instead, and we'd either need readline or need to
> reinvent it for that....
But doesn't the original "single-keypress" theme shares that problem
anyway? It trades the ability to "delete some of the it again if he
decides to" away, in exchange for something else (probably "quicker input"
or "perceived ease of use").
> .... On the other hand, some possible choices might
> be a valid prefix of some _other_ choices, at which point you need a
> terminator (such as the <enter>) anyway. I expect this to be fairly
> common since many of the list_and_choose() prompts are numbered, so
> that 1 and 10 run into this problem.
I think that is independent, is an easy to fix (e.g. 1..9 A B C...Z), and
is a chicken-and-egg issue. If the input mechanism had "enough leading
letters to disambiguate" semantics from the beginning, I am reasonably
sure that list_and_choose() would have implemented its choice as not small
integers but distinct letters.
next prev parent reply other threads:[~2009-02-04 5:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 20:35 [RFC PATCH] add -p: prompt for single characters Thomas Rast
2009-02-02 3:31 ` Suraj Kurapati
2009-02-02 8:34 ` Thomas Rast
2009-02-02 8:50 ` Junio C Hamano
2009-02-02 21:46 ` [PATCH 0/4] add -p: Term::ReadKey and more Thomas Rast
2009-02-02 21:46 ` [PATCH 1/4] add -p: change prompt separator for 'g' Thomas Rast
2009-02-02 21:46 ` [PATCH 2/4] add -p: trap Ctrl-D in 'goto' mode Thomas Rast
2009-02-02 21:46 ` [PATCH 3/4] add -p: optionally prompt for single characters Thomas Rast
2009-02-03 6:24 ` Jeff King
2009-02-03 8:54 ` [Illustration PATCH] add -i: accept single-keypress input Thomas Rast
2009-02-03 9:05 ` Junio C Hamano
2009-02-03 9:35 ` Thomas Rast
2009-02-04 5:10 ` Junio C Hamano [this message]
2009-02-04 8:51 ` Thomas Rast
2009-02-04 19:42 ` [PATCH 3/4] add -p: optionally prompt for single characters Thomas Rast
2009-02-04 20:08 ` [PATCH v2 3/4] add -p: " Thomas Rast
2009-02-04 20:08 ` [PATCH v2 4/4] add -p: print errors in separate color Thomas Rast
2009-02-04 20:12 ` [PATCH v3 3/4] add -p: prompt for single characters Thomas Rast
2009-02-04 20:12 ` [PATCH v3 4/4] add -p: print errors in separate color Thomas Rast
2009-02-04 20:40 ` [PATCH 3/4] add -p: optionally prompt for single characters Junio C Hamano
2009-02-05 8:28 ` [PATCH v4 3/4] add -p: " Thomas Rast
2009-02-06 14:01 ` Jeff King
2009-02-06 19:30 ` [PATCH] add -p: import Term::ReadKey with 'require' Thomas Rast
2009-02-06 20:30 ` Jeff King
2009-02-06 23:21 ` Thomas Rast
2009-02-07 4:54 ` Jeff King
2009-02-07 7:50 ` Junio C Hamano
2009-02-05 8:28 ` [PATCH v4 4/4] add -p: print errors in separate color Thomas Rast
2009-02-02 21:46 ` [PATCH 4/4] add -p: print errors in help colors Thomas Rast
2009-02-02 13:19 ` [RFC PATCH] add -p: prompt for single characters Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljsm9492.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sunaku@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).