git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Kjetil Barvik <barvik@broadpark.no>,
	git@vger.kernel.org, Pete Harlan <pgit@pcharlan.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH/RFC v5 1/1] more cache effective symlink/directory detection
Date: Sat, 10 Jan 2009 16:48:15 -0800	[thread overview]
Message-ID: <7vljtivfao.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <49687440.5090506@lsrfire.ath.cx> (René Scharfe's message of "Sat, 10 Jan 2009 11:11:12 +0100")

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Kjetil Barvik schrieb:
>> - Also introduce a 'void clear_lstat_cache(void)' function, which
>>   should be used to clean the cache before usage.  If for instance,
>>   you have changed the types of directories which should be cached,
>>   the cache could contain a path which was not wanted.
>
> Is it possible to make the cache detect these situations automatically
> by saving track_flags along with the cache contents?  Not having to
> clear the cache manually would be a major feature.

> Also, it's probably worth to split this patch up again.  First switching
> to your improved implementation of has_symlink_leading_path(), then
> introducing has_symlink_or_noent_leading_path() and finally adding
> LSTAT_FULLPATH and the fourth parameter of lstat_cache() etc. and using
> this feature in entry.c seems like a nice incremental progression.

Both are reasonable suggestions.  Thanks.

  reply	other threads:[~2009-01-11  0:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-09 19:05 [PATCH/RFC v5 0/1] git checkout: optimise away lots of lstat() calls Kjetil Barvik
2009-01-09 19:05 ` [PATCH/RFC v5 1/1] more cache effective symlink/directory detection Kjetil Barvik
2009-01-10 10:11   ` René Scharfe
2009-01-11  0:48     ` Junio C Hamano [this message]
2009-01-11  8:26       ` Kjetil Barvik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vljtivfao.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=barvik@broadpark.no \
    --cc=git@vger.kernel.org \
    --cc=pgit@pcharlan.com \
    --cc=rene.scharfe@lsrfire.ath.cx \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).