* Remove feature_grep in gitweb?
@ 2008-12-07 5:22 Matt Kraai
2008-12-07 9:36 ` [PATCH] gitweb: Make project specific override for 'grep' feature work Jakub Narebski
0 siblings, 1 reply; 4+ messages in thread
From: Matt Kraai @ 2008-12-07 5:22 UTC (permalink / raw)
To: git
Howdy,
A feature_grep subroutine is defined in gitweb.perl, but unlike the
other feature_* subroutines there, it doesn't appear to be used
anywhere. Should it be removed?
--
Matt http://ftbfs.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] gitweb: Make project specific override for 'grep' feature work
2008-12-07 5:22 Remove feature_grep in gitweb? Matt Kraai
@ 2008-12-07 9:36 ` Jakub Narebski
2008-12-07 10:52 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Narebski @ 2008-12-07 9:36 UTC (permalink / raw)
To: git; +Cc: Matt Kraai
The 'grep' feature was marked in the comments as having project
specific config, but it lacked 'sub' key required for it to work.
Kind-of-Noticed-by: Matt Kraai <kraai@ftbfs.org>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Matt Kraai wrote:
> A feature_grep subroutine is defined in gitweb.perl, but unlike the
> other feature_* subroutines there, it doesn't appear to be used
> anywhere. Should it be removed?
No, it was oversight; it should be used in setting up 'grep' %feature
configuration, see below.
Thanks for catching this.
gitweb/gitweb.perl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 95988fb..9517392 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -241,6 +241,7 @@ our %feature = (
# $feature{'grep'}{'override'} = 1;
# and in project config gitweb.grep = 0|1;
'grep' => {
+ 'sub' => \&feature_grep,
'override' => 0,
'default' => [1]},
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-12-07 11:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-07 5:22 Remove feature_grep in gitweb? Matt Kraai
2008-12-07 9:36 ` [PATCH] gitweb: Make project specific override for 'grep' feature work Jakub Narebski
2008-12-07 10:52 ` Junio C Hamano
2008-12-07 11:16 ` Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).