From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Miklos Vajna <vmiklos@frugalware.org>, git@vger.kernel.org
Subject: Re: [PATCH] t7501: always use test_cmp instead of diff
Date: Tue, 09 Sep 2008 17:02:09 -0700 [thread overview]
Message-ID: <7vljy03m2m.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080909235414.GA4768@coredump.intra.peff.net> (Jeff King's message of "Tue, 9 Sep 2008 19:54:14 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Sep 10, 2008 at 01:41:06AM +0200, Miklos Vajna wrote:
>
>> test_expect_success \
>> 'validate git-rev-list output.' \
>> - 'diff current expected'
>> + 'test_cmp current expected'
>
> We seem to use the convention of
>
> test_cmp <expected> <actual>
>
> elsewhere, rather than
>
> test_cmp <actual> <expected>
>
> as you have here. Most noticeably, that means the diff will show
> deviations from expected, rather "what should be done to make this as
> expected".
Yes, please. I am glad to see somebody noticed it (I've been fixing these
whenever I touched vicinity of the ones that had comparisons swapped).
next prev parent reply other threads:[~2008-09-10 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 23:41 [PATCH] t7501: always use test_cmp instead of diff Miklos Vajna
2008-09-09 23:49 ` Miklos Vajna
2008-09-09 23:54 ` Jeff King
2008-09-10 0:02 ` Junio C Hamano [this message]
2008-09-10 17:32 ` Miklos Vajna
-- strict thread matches above, loose matches on Subject: below --
2008-09-09 23:37 Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljy03m2m.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).