From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Nanako Shiraishi <nanako3@lavabit.com>, git@vger.kernel.org
Subject: Re: [PATCH 6/6] t9400, t9401: use "git cvsserver" without dash
Date: Tue, 09 Sep 2008 21:13:04 -0700 [thread overview]
Message-ID: <7vljy0zlin.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080909215635.GA4226@coredump.intra.peff.net> (Jeff King's message of "Tue, 9 Sep 2008 17:56:35 -0400")
Jeff King <peff@peff.net> writes:
> On Tue, Sep 09, 2008 at 02:38:31PM -0700, Junio C Hamano wrote:
>
>> My eyes are getting dry after looking at these s/git-/git / patches, so
>> please do not get offended if I leave these in my Inbox unread for a few
>> days.
>
> I did the same "look for conversion that should _not_ have occurred"
> check for these patches, and all look sane with two exceptions:
>
> - the cvsserver stuff that you mentioned
>
> - patch 4/6 changes the commit log message in a few cases for some "git
> svn" tests; presumably nothing is caring about the commit id's
> generated here, but I don't actually have svn installed to run the
> tests to be sure
Thanks. Will make sure I run these tests (I do not know offhand which svn
tests I am skipping).
next prev parent reply other threads:[~2008-09-10 4:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 21:25 [PATCH 6/6] t9400, t9401: use "git cvsserver" without dash Nanako Shiraishi
2008-09-09 21:38 ` Junio C Hamano
2008-09-09 21:56 ` Jeff King
2008-09-10 4:13 ` Junio C Hamano [this message]
2008-09-10 11:03 ` Nanako Shiraishi
2008-09-10 22:37 ` Junio C Hamano
2008-10-28 11:16 ` Dmitry V. Levin
2008-10-28 15:57 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2008-09-09 21:50 Nanako Shiraishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljy0zlin.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).