From: Junio C Hamano <gitster@pobox.com>
To: Olivier Marin <dkr+ml.git@free.fr>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] tests: use $TEST_DIRECTORY to refer to the t/ directory
Date: Sat, 09 Aug 2008 16:20:36 -0700 [thread overview]
Message-ID: <7vljz54vy3.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <489E1FDB.5070700@free.fr> (Olivier Marin's message of "Sun, 10 Aug 2008 00:53:15 +0200")
Olivier Marin <dkr+ml.git@free.fr> writes:
> Junio C Hamano a écrit :
>>
>> all the tests still pass, but we would want extra sets of eyeballs on this
>> type of change to really make sure.
>
> OK, I read the diff and found some trivial quoting issues that will break the
> following tests if $TEST_DIRECTORY contain a space:
>
>> t/t4101-apply-nonl.sh | 2 +-
>> t/t5100-mailinfo.sh | 18 +++++++++---------
>> t/t7500-commit.sh | 16 ++++++++--------
Ah, GIT_EDITOR is dereferenced twice. Sheesh.
We could probably use test_set_editor() function from test-lib.sh, hmm?
next prev parent reply other threads:[~2008-08-09 23:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 5:59 [PATCH 0/3] Enable parallelized tests Johannes Schindelin
2008-08-08 5:59 ` [PATCH 1/3] t9700: remove useless check Johannes Schindelin
2008-08-08 5:59 ` [PATCH 2/3] tests: Clarify dependencies between tests, 'aggregate-results' and 'clean' Johannes Schindelin
2008-08-08 5:59 ` [PATCH 3/3] Enable parallel tests Johannes Schindelin
2008-08-08 6:52 ` Junio C Hamano
2008-08-08 10:26 ` Johannes Schindelin
2008-08-08 10:33 ` Junio C Hamano
2008-08-08 7:44 ` René Scharfe
2008-08-08 8:28 ` Junio C Hamano
2008-08-08 9:31 ` [PATCH] tests: use $TEST_DIRECTORY to refer to the t/ directory Junio C Hamano
2008-08-08 10:35 ` Johannes Schindelin
2008-08-08 10:40 ` Junio C Hamano
2008-08-08 14:40 ` Stephan Beyer
2008-08-09 22:53 ` Olivier Marin
2008-08-09 23:20 ` Junio C Hamano [this message]
2008-08-10 7:33 ` Junio C Hamano
2008-08-08 10:37 ` [PATCH 3/3] Enable parallel tests Johannes Schindelin
2008-08-08 11:08 ` [PATCH 3/3 v2] " Johannes Schindelin
2008-08-08 15:03 ` Stephan Beyer
2008-08-08 15:27 ` Johannes Schindelin
2008-08-08 15:36 ` [PATCH 0/3] Enable parallelized tests SZEDER Gábor
2008-08-08 16:02 ` Stephan Beyer
2008-08-08 16:30 ` Johannes Schindelin
2008-08-08 16:33 ` Stephan Beyer
2008-08-08 16:51 ` Johannes Schindelin
2008-08-08 16:56 ` Stephan Beyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljz54vy3.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dkr+ml.git@free.fr \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).