From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Christian Couder <chriscool@tuxfamily.org>,
git@vger.kernel.org, Miklos Vajna <vmiklos@frugalware.org>
Subject: Re: [RFC/PATCH v2] merge-base: teach "git merge-base" to accept more than 2 arguments
Date: Sun, 27 Jul 2008 11:11:22 -0700 [thread overview]
Message-ID: <7vljzn2o51.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0807271631470.5526@eeepc-johanness> (Johannes Schindelin's message of "Sun, 27 Jul 2008 16:38:05 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> BTW I seem to recall that get_merge_bases_many() was _not_ the same as
> get_merge_octopus(). Could you please remind me what _many() does?
I explained what merge-bases-many gives in a separate message last night
with pictures.
get_merge_octopus() is a more or less useless function. It is there only
because the protocol between "merge" and strategies requires that the
former have to pass _some_ bases to the latter. In fact, the octopus
strategy implementation completely ignores the heads given by "merge";
a single set of merge base given from outside is not even useful when you
build octopus by repeatedly running pairwise three-way merges.
With Christian's git-merge-base enhancement, the big comment at the end of
git-merge-octopus's main loop can go with a much improved "next" merge
base computation.
next prev parent reply other threads:[~2008-07-27 18:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 3:33 [RFC/PATCH v2] merge-base: teach "git merge-base" to accept more than 2 arguments Christian Couder
2008-07-27 4:47 ` Junio C Hamano
2008-07-28 6:10 ` Christian Couder
2008-07-28 6:18 ` Junio C Hamano
2008-07-27 14:38 ` Johannes Schindelin
2008-07-27 15:28 ` Miklos Vajna
2008-07-27 18:11 ` Junio C Hamano [this message]
2008-07-27 20:44 ` Johannes Schindelin
2008-07-27 20:47 ` Re* " Junio C Hamano
2008-07-28 5:49 ` Christian Couder
2008-07-27 15:02 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljzn2o51.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).