From: Junio C Hamano <gitster@pobox.com>
To: "P. Christeas" <p_christ@hol.gr>
Cc: git@vger.kernel.org, Gerrit Pape <pape@smarden.org>
Subject: Re: [PATCH] Fix git-svnimport against libsvn_ra.
Date: Wed, 23 Jul 2008 12:09:02 -0700 [thread overview]
Message-ID: <7vljzsct9t.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200807231008.39455.p_christ@hol.gr> (P. Christeas's message of "Wed, 23 Jul 2008 10:10:28 +0300")
Thanks.
But the one line description is not descriptive enough, don't you think?
Imagine this line (and nothing else from what you wrote in the body text)
appearing among 100 other commits. Can you tell what this commit is about
3 months from now on?
Perhaps:
svnimport: newer libsvn wants us to ask for the root with "", not "/"
> In r27729, libsvn introduced an assert which explicitly
> forbids searching the tree at "/". Luckily enough, it
> still accepts an empty string "" as the starting point.
I think you implied by saying "still", asking with an empty string had the
same effect as asking for the root "/" in earlier versions of SVN, and the
patch will not break people with older libsvn. Is that correct?
> http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra/ra_loader.c?r1=27653&r2=27729
> ---
Sign-off, please?
prev parent reply other threads:[~2008-07-23 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 7:10 [PATCH] Fix git-svnimport against libsvn_ra P. Christeas
2008-07-23 19:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljzsct9t.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=p_christ@hol.gr \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).