git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, David Bremner <bremner@unb.ca>
Subject: Re: git status in clean working dir
Date: Mon, 21 Jul 2008 19:48:02 -0700	[thread overview]
Message-ID: <7vljzur5wd.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vtzeir68z.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 21 Jul 2008 19:40:28 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Actually, the situation is now even worse than I originally thought
> especially with Jeff's pager.<cmd> patch on 'master' recently.  For
> example, you can screw yourself quite badly by forcing diff-files used in
> the scripts you run to page, defeating --exit-code option.  Which means
>
>  (1) It hurts?  Don't do it then; but
>
>  (2) Then why are we even allowing to configure the plumbing to page?
>
> Should we maintain a table of commands that we allow paging to be
> customized, and ignore pager.<cmd> for commands that are not in the list?
>
> Which codepath should issue error messages when the user tries to break
> the system by saying "pager.diff-files = true"?

Another possibility is to set up an extra process whose sole purpose is to
wait for the main process that feeds the pager pipe and relay its exit
status to the outside world.  But I do not think we would want to go
there...

  reply	other threads:[~2008-07-22  2:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21 23:13 git status in clean working dir David Bremner
2008-07-22  2:30 ` Junio C Hamano
2008-07-22  2:36   ` Abhijit Menon-Sen
2008-07-22  2:40   ` Junio C Hamano
2008-07-22  2:48     ` Junio C Hamano [this message]
2008-07-22  4:44       ` Jeff King
2008-07-22  4:52         ` Jeff King
2008-07-22 11:24           ` Johannes Schindelin
2008-07-22  4:41     ` Jeff King
2008-07-22  5:39       ` Mike Hommey
2008-07-22  6:06         ` Jeff King
2008-07-22  6:18           ` Mike Hommey
2008-07-22  6:46             ` Jeff King
2008-07-22  7:10               ` Jeff King
2008-07-22  7:12                 ` [PATCH 1/2] run-command: add pre-exec callback Jeff King
2008-07-22  7:14                   ` [PATCH 2/2] spawn pager via run_command interface Jeff King
2008-07-22  7:16                     ` Jeff King
2008-07-22  7:31                       ` Pierre Habouzit
2008-07-22  7:49                         ` Jeff King
2008-07-22  7:48                       ` Johannes Sixt
2008-07-22  7:50                         ` Jeff King
2008-07-22  8:29                           ` Johannes Sixt
2008-07-22  9:17                 ` git status in clean working dir Junio C Hamano
2008-07-22  9:40                   ` Jeff King
2008-07-22 14:10           ` David Bremner
2008-07-22  7:34       ` Johannes Sixt
2008-07-22  7:46         ` Jeff King
2008-07-22  7:54           ` Johannes Sixt
2008-07-24  6:56     ` Ask Bjørn Hansen
2008-07-24 16:54       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vljzur5wd.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=bremner@unb.ca \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).