git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] t5700-clone-reference: Quote $U
@ 2008-05-27  7:36 Johannes Sixt
  2008-05-28  4:29 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Sixt @ 2008-05-27  7:36 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Git Mailing List, Johannes Sixt

The new "trash directory" bites again.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---
 t/t5700-clone-reference.sh |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/t5700-clone-reference.sh b/t/t5700-clone-reference.sh
index e1ca730..1c10916 100755
--- a/t/t5700-clone-reference.sh
+++ b/t/t5700-clone-reference.sh
@@ -52,13 +52,13 @@ diff expected current'
 
 cd "$base_dir"
 
-rm -f $U
+rm -f "$U"
 
 test_expect_success 'cloning with reference (no -l -s)' \
-'GIT_DEBUG_SEND_PACK=3 git clone --reference B "file://$(pwd)/A" D 3>$U'
+'GIT_DEBUG_SEND_PACK=3 git clone --reference B "file://$(pwd)/A" D 3>"$U"'
 
 test_expect_success 'fetched no objects' \
-'! grep "^want" $U'
+'! grep "^want" "$U"'
 
 cd "$base_dir"
 
-- 
1.5.5.1.125.gb9f88

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] t5700-clone-reference: Quote $U
  2008-05-27  7:36 [PATCH] t5700-clone-reference: Quote $U Johannes Sixt
@ 2008-05-28  4:29 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2008-05-28  4:29 UTC (permalink / raw)
  To: Johannes Sixt; +Cc: Git Mailing List

Good eyes.  "! grep $pattern $U" was failing not because we did not emit the
pattern but because we passed a bogus unquoted $U.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-28  4:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-27  7:36 [PATCH] t5700-clone-reference: Quote $U Johannes Sixt
2008-05-28  4:29 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).