From: Junio C Hamano <gitster@pobox.com>
To: Paul Oliver <puzza007@gmail.com>
Cc: git@vger.kernel.org, Miklos Vajna <vmiklos@frugalware.org>
Subject: Re: [PATCH] [ is explicitly disallowed by bad_ref_char
Date: Fri, 23 May 2008 10:58:03 -0700 [thread overview]
Message-ID: <7vlk20sy1g.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080523103906.GO27724@genesis.frugalware.org> (Miklos Vajna's message of "Fri, 23 May 2008 12:39:06 +0200")
Miklos Vajna <vmiklos@frugalware.org> writes:
> On Fri, May 23, 2008 at 09:42:04AM +0100, Paul Oliver <puzza007@gmail.com> wrote:
>> ---
>> git-cvsimport.perl | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> Could you please improve the commit message a bit? Just running git-log
> won't let to you know this patch touches git-cvsimport only, which is an
> important information here.
Also please sign-off your patch.
prev parent reply other threads:[~2008-05-23 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 8:42 [PATCH] [ is explicitly disallowed by bad_ref_char Paul Oliver
2008-05-23 10:39 ` Miklos Vajna
2008-05-23 17:58 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk20sy1g.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=puzza007@gmail.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).