From: Junio C Hamano <gitster@pobox.com>
To: "martin f. krafft" <madduck@madduck.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Export GIT_DIR after setting it
Date: Thu, 15 May 2008 10:23:57 -0700 [thread overview]
Message-ID: <7vlk2bh45u.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080515101523.GA31719@lapse.madduck.net> (martin f. krafft's message of "Thu, 15 May 2008 11:15:23 +0100")
"martin f. krafft" <madduck@madduck.net> writes:
> The only problem I see now is when an external command (or the shell
> script) can't properly deal with GIT_DIR being set, but then that's
> a whole different bug.
One thing that we did not have to worry about when git-sh-setup was
invented is GIT_WORK_TREE and its cousin core.worktree. When the user
uses GIT_DIR _but_ wants to work from a subdirectory of the checked out
work tree, the user _must_ tell git where the top of the work tree is; in
other words, setting and exporting only GIT_DIR is a misconfiguration.
I have a suspicion that "the whole different bug" is what bit you --
perhaps some places need to also set and export GIT_WORK_TREE as well when
the do GIT_DIR.
next prev parent reply other threads:[~2008-05-15 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 23:23 [PATCH] Export GIT_DIR after setting it martin f. krafft
2008-05-15 2:25 ` Junio C Hamano
2008-05-15 10:15 ` martin f. krafft
2008-05-15 17:23 ` Junio C Hamano [this message]
2008-05-15 17:55 ` Björn Steinbrink
2008-05-15 18:28 ` martin f. krafft
2008-05-15 18:44 ` Björn Steinbrink
2008-05-16 21:50 ` martin f. krafft
2008-05-20 16:17 ` martin f. krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk2bh45u.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madduck@madduck.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).