From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Richard Quirk <richard.quirk@gmail.com>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] git-cherry: add color to the output
Date: Sun, 04 May 2008 22:14:32 -0700 [thread overview]
Message-ID: <7vlk2pnxhj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080505032718.GA15498@sigill.intra.peff.net> (Jeff King's message of "Sun, 4 May 2008 23:27:18 -0400")
Jeff King <peff@peff.net> writes:
> On Fri, May 02, 2008 at 08:01:44PM +0200, Richard Quirk wrote:
>
>> If color.diff is set then patches not yet cherry-picked are marked green
>> and already picked ones are marked red. This makes it easier to tell at a
>> glance which changes have not been cherry-picked.
>
> I don't actually use git-cherry, so I can't say whether this is useful
> or not. But I wonder if it should follow the trend of other color
> options and get its own color.cherry variable, but also be controlled by
> the master color.ui.
I do not use git-cherry as Porcelain nor did I design it to be used as
such. "color.cherry = always" would worry me but the user is asking for
trouble if he did so, so perhaps it is Ok.
prev parent reply other threads:[~2008-05-05 5:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:01 [PATCH] git-cherry: add color to the output Richard Quirk
2008-05-05 3:27 ` Jeff King
2008-05-05 5:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk2pnxhj.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=richard.quirk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).