From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Teemu Likonen <tlikonen@iki.fi>, git@vger.kernel.org
Subject: Re: BUG: "git checkout" displays Q-escaped commit titles
Date: Sat, 03 May 2008 18:54:10 -0700 [thread overview]
Message-ID: <7vlk2qsukd.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080502140536.GA3518@sigill.intra.peff.net> (Jeff King's message of "Fri, 2 May 2008 10:05:36 -0400")
Jeff King <peff@peff.net> writes:
> .... It seems like pp_title_line should perhaps just be checking
> for fmt == CMIT_FMT_EMAIL, but I'm not sure if that would break anything
> else,...
Yeah, your patch obviously would fix the caller, as subject and
after_subject should not be given unless you are doing FMT_EMAIL. But I
also think we should not even look at subject and after_subject unless fmt
is CMIT_FMT_EMAIL inside pp_title_line().
next prev parent reply other threads:[~2008-05-04 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 13:39 BUG: "git checkout" displays Q-escaped commit titles Teemu Likonen
2008-05-02 14:05 ` Jeff King
2008-05-04 1:54 ` Junio C Hamano [this message]
2008-05-04 19:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk2qsukd.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=tlikonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).