From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@cam.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] pack-objects: proper pack time stamping with --max-pack-size
Date: Thu, 13 Mar 2008 22:13:04 -0700 [thread overview]
Message-ID: <7vlk4lubvj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0803140035260.2947@xanadu.home> (Nicolas Pitre's message of "Fri, 14 Mar 2008 00:39:02 -0400 (EDT)")
Nicolas Pitre <nico@cam.org> writes:
>> > diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
>> > index f504cff..4c2ed70 100644
>> > --- a/builtin-pack-objects.c
>> > +++ b/builtin-pack-objects.c
>> > @@ -17,6 +17,8 @@
>> > #include "progress.h"
>> > #include "refs.h"
>> >
>> > +#include <utime.h>
>> > +
>>
>> Hmmm. Shouldn't this go to git-compat-util.h?
>
> Maybe... if you say so.
>
> The whole header file arrangement logic is somewhat escaping my mind, so
> I simply decided to do the same as in test-chmtime.c.
The general idea is to isolate the place system headers are included at,
so that we have to worry about the inclusion and feature-macro definition
order at only one place (see for example the hack about _ALL_SOURCE to
work around AIX 5.3, yuck).
prev parent reply other threads:[~2008-03-14 5:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 18:59 [PATCH] pack-objects: proper pack time stamping with --max-pack-size Nicolas Pitre
2008-03-13 20:59 ` Junio C Hamano
2008-03-14 4:33 ` Junio C Hamano
2008-03-14 4:39 ` Nicolas Pitre
2008-03-14 5:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk4lubvj.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).