git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH v3] builtin-fsck: reports missing parent commits
Date: Sun, 24 Feb 2008 19:08:52 -0800	[thread overview]
Message-ID: <7vlk59pwaj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 12038867362489-git-send-email-mkoegler@auto.tuwien.ac.at

Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:

> Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>

As far as I can tell, the new test is not testing the commit
object we are looking at from the object database.  What it is
testing is if the code that parsed and prepared the information
in "struct commit" found the same number of parents an extra
check we are doing here by hand (if not grafted --- but
presumably whoever gave the struct commit we are handling here
would have obtained that information by doing the same parsing),
or the parsing of the graft file (when grafted --- but
presumably whoever gave the struct commit we are handling here
would have obtained that information by calling the same
llokup_commit_graft()).

So I am not sure what problems in the repository objects these
new checks are designed to catch.

This needs a lot of explanation than what's in your commit log
message.

  reply	other threads:[~2008-02-25  3:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-24 20:58 [PATCH v3] builtin-fsck: reports missing parent commits Martin Koegler
2008-02-25  3:08 ` Junio C Hamano [this message]
2008-02-25  7:16   ` Martin Koegler
2008-02-25  7:24     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vlk59pwaj.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mkoegler@auto.tuwien.ac.at \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).