From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff.c: replace a 'strdup' with 'xstrdup'.
Date: Fri, 15 Feb 2008 09:11:07 -0800 [thread overview]
Message-ID: <7vlk5mi1qs.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20080214065000.083c3617.chriscool@tuxfamily.org
Christian Couder <chriscool@tuxfamily.org> writes:
> By the way perhaps the
>
> return error("%s: lacks value", var);
>
> should also be changed to
>
> return config_error_nonbool(var);
Good eyes. That probably should go to 'maint' for consistency.
prev parent reply other threads:[~2008-02-15 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 5:50 [PATCH] diff.c: replace a 'strdup' with 'xstrdup' Christian Couder
2008-02-15 17:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk5mi1qs.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).