git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Stephen Sinclair <radarsat1@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.
Date: Fri, 11 Jan 2008 21:30:24 -0800	[thread overview]
Message-ID: <7vlk6vy5jj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vprw7y6mz.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Fri, 11 Jan 2008 21:06:44 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> Jeff King <peff@peff.net> writes:
>
>> This is obviously not 1.5.4 material, so I haven't given it that much
>> thought either. But perhaps Stephen's "author message" should simply
>> trigger any time the author is pulled from gecos?

I think what we could do if we wanted to protect people from
unconfigured identity is to stop pulling names from gecos and
hostname, and respect _only_ environment and config.

And fail any operation that we would want configured name and
email (names in reflog does not count as such an operation ---
we've made that mistake once, which made "git clone" impossible
before setting up $HOME/.gitconfig).

That I think I can live with.

If we do that, we do not have to see two extra lines (COMMITTER
and AUTHOR) that spells our own name in the commit message
buffer, which almost always will be a total waste of space.

  reply	other threads:[~2008-01-12  5:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-11 20:10 [PATCH] Add committer and author names to top of COMMIT_EDITMSG Stephen Sinclair
2008-01-11 21:26 ` Johannes Schindelin
2008-01-11 23:36 ` Junio C Hamano
2008-01-12  0:09   ` Stephen Sinclair
2008-01-12  0:22     ` Junio C Hamano
2008-01-12  1:33       ` Stephen Sinclair
2008-01-12  1:53         ` Junio C Hamano
2008-01-12  2:25           ` Stephen Sinclair
2008-01-12  4:57             ` Junio C Hamano
2008-01-12  7:26               ` Stephen Sinclair
2008-01-12  8:02                 ` Junio C Hamano
2008-01-12  4:52           ` Jeff King
2008-01-12  5:06             ` Junio C Hamano
2008-01-12  5:30               ` Junio C Hamano [this message]
2008-01-12  5:32                 ` Jeff King
2008-01-12  5:56                   ` Junio C Hamano
2008-01-12  5:58                     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vlk6vy5jj.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=radarsat1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).