From: Junio C Hamano <gitster@pobox.com>
To: Wincent Colaiuta <win@wincent.com>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] builtin-add: fix command line building to call interactive
Date: Sun, 25 Nov 2007 10:36:29 -0800 [thread overview]
Message-ID: <7vlk8mmatu.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <F09249EB-475A-4352-A3A1-A8B15D2A94FF@wincent.com> (Wincent Colaiuta's message of "Sun, 25 Nov 2007 19:27:24 +0100")
Wincent Colaiuta <win@wincent.com> writes:
> El 25/11/2007, a las 19:07, Junio C Hamano escribi> The earlier 7c0ab4458994aa895855abc4a504cf693ecc0cf1 (Teach builtin-
>> add
>> to pass multiple paths to git-add--interactive) did not allocate
>> enough,
>
> Yes, it was off by one; sorry about that. You may have noticed that I
> fixed that up in the patches I sent out yesterday and today. May need
> to redo them now to apply on top of this.
I'd suggest you to slow down, apply the two patches on top of 'next' and
take a look at the result.
I _think_ the only remaining thing is --patch, and none of the pathspec
thing is needed.
next prev parent reply other threads:[~2007-11-25 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 13:15 [PATCH 0/3] Updates to git-add--interactive Wincent Colaiuta
2007-11-25 13:15 ` [PATCH 1/3] Rename patch_update_file function to patch_update_pathspec Wincent Colaiuta
2007-11-25 13:15 ` [PATCH 2/3] Move pathspec validation into interactive_add Wincent Colaiuta
2007-11-25 13:15 ` [PATCH 3/3] Add "--patch" option to git-add--interactive Wincent Colaiuta
2007-11-25 18:11 ` [PATCH 1/3] Rename patch_update_file function to patch_update_pathspec Junio C Hamano
2007-11-25 18:07 ` [PATCH] builtin-add: fix command line building to call interactive Junio C Hamano
2007-11-25 18:27 ` Wincent Colaiuta
2007-11-25 18:36 ` Junio C Hamano [this message]
2007-11-25 19:02 ` Wincent Colaiuta
2007-11-25 19:48 ` Junio C Hamano
2007-11-26 4:14 ` Jeff King
2007-11-25 18:10 ` [PATCH] add -i: Fix running from a subdirectory Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk8mmatu.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).