From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix t7004 which fails with retarded sed
Date: Fri, 16 Nov 2007 11:36:42 -0800 [thread overview]
Message-ID: <7vlk8yx9rp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071116191715.GB7624@glandium.org> (Mike Hommey's message of "Fri, 16 Nov 2007 20:17:15 +0100")
Mike Hommey <mh@glandium.org> writes:
>> So the earlier part of the test
>>
>> GIT_EDITOR=cat git tag -a initial-comment > actual || true &&
>>
>> is already bogus with respect to the latter point. It will
>> happily continue if "git tag" erroneously returns success, and
>> the above does not catch it.
>>
>> if GIT_EDITOR=cat git tag -a initial-comment >actual
>> then
>> echo >&2 oops we should have errored out
>> false
>> else
>> : happy -- anything else we want to check?
>> fi
>
> This should probably be tested in another test block.
Fair enough; please make it so.
> Which is roughly what my patch does, except it doesn't check for
> ordering.
... which I think is more important part. If the blank like
were at the end, that would be irritating for the user, wouldn't
it?
next prev parent reply other threads:[~2007-11-16 19:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 13:38 [BUG] t7004 (master) busted on Leopard Wincent Colaiuta
2007-11-15 14:37 ` Johannes Schindelin
2007-11-15 14:48 ` David Kastrup
2007-11-15 15:12 ` Wincent Colaiuta
2007-11-15 15:16 ` [PATCH] Fix git-tag test breakage caused by broken sed " Wincent Colaiuta
2007-11-15 15:47 ` [PATCH v2] " Wincent Colaiuta
[not found] ` <7v4pfm3h6f.fsf@gitster.siamese.dyndns.org>
2007-11-16 13:45 ` Wincent Colaiuta
2007-11-16 13:48 ` Wincent Colaiuta
2007-11-16 16:59 ` Mike Hommey
2007-11-16 17:25 ` Wincent Colaiuta
2007-11-16 17:26 ` [PATCH] Fix t7004 which fails with retarded sed Mike Hommey
2007-11-16 17:58 ` Benoit Sigoure
2007-11-16 19:15 ` Mike Hommey
2007-11-16 18:02 ` Wincent Colaiuta
2007-11-16 18:26 ` Junio C Hamano
2007-11-16 19:17 ` Mike Hommey
2007-11-16 19:36 ` Junio C Hamano [this message]
2007-11-16 20:28 ` [PATCH] Fix and improve t7004 Mike Hommey
2007-11-16 21:04 ` Benoit Sigoure
2007-11-16 21:11 ` Mike Hommey
2007-11-16 21:31 ` Benoit Sigoure
2007-11-16 21:35 ` Mike Hommey
2007-11-16 21:47 ` Benoit Sigoure
2007-11-16 21:42 ` Junio C Hamano
2007-11-16 22:02 ` Mike Hommey
2007-11-17 8:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk8yx9rp.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).