From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Andy C <andychup@gmail.com>
Subject: Re: [PATCH/RFC 0/3] faster inexact rename handling
Date: Tue, 30 Oct 2007 01:29:22 -0700 [thread overview]
Message-ID: <7vlk9lm2e5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LFD.0.999.0710292156580.30120@woody.linux-foundation.org
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Tue, 30 Oct 2007, Jeff King wrote:
>>
>> - no improvement on smaller datasets. Running "git-whatchanged -M
>> --raw -l0" on the linux-2.6 repo takes about the same time with the
>> old and new code (presumably the algorithmic savings of the new code
>> are lost in a higher constant factor, so when n is small, it is a
>> wash).
>
> Have you compared the results? IOW, does it find the *same* renames?
>
> I'm a bit worried about the fact that you just pick a single (arbitrary)
> src/dst per fingerprint. Yes, it should be limited, but that seems to be a
> bit too *extremely* limited. But if it gives the same results in practice,
> maybe nobody cares?
If it always gives the same results in practice, obviously
nobody can even notice.
However, merging this series to 'pu' breaks rebase-merge test
t3402 among other things.
next prev parent reply other threads:[~2007-10-30 8:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 4:21 [PATCH/RFC 0/3] faster inexact rename handling Jeff King
2007-10-30 4:23 ` [PATCH/RFC 1/3] change hash table calling conventions Jeff King
2007-10-30 4:24 ` [PATCH/RFC 2/3] introduce generic similarity library Jeff King
2007-10-30 4:24 ` [PATCH/RFC 3/3] handle renames using similarity engine Jeff King
2007-10-30 5:06 ` [PATCH/RFC 0/3] faster inexact rename handling Linus Torvalds
2007-10-30 8:29 ` Junio C Hamano [this message]
2007-10-30 13:46 ` Jeff King
2007-10-30 13:43 ` Jeff King
2007-10-30 15:38 ` Linus Torvalds
2007-10-30 20:20 ` Jeff King
2007-10-30 20:39 ` Linus Torvalds
2007-10-31 0:27 ` Andy C
2007-10-31 0:06 ` Andy C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk9lm2e5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=andychup@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).