git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Scott R Parish <srp@srparish.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/7] use only the $PATH for exec'ing git commands
Date: Sat, 27 Oct 2007 23:18:12 -0700	[thread overview]
Message-ID: <7vlk9nzrrv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1193474215-6728-5-git-send-email-srp@srparish.net

Scott R Parish <srp@srparish.net> writes:

> diff --git a/exec_cmd.c b/exec_cmd.c
> index 8b681d0..c228dbf 100644
> --- a/exec_cmd.c
> +++ b/exec_cmd.c
> @@ -29,85 +29,68 @@ const char *git_exec_path(void)
>  	return builtin_exec_path;
>  }
>  
> +static void add_path(struct strbuf *out, const char *path)
> +{
> +	if (path && strlen(path)) {

I wonder if s/strlen(path)/*path/ micro-optimization is worth
doing.  Ideally, if built-in strlen() is used, the compiler
should be clever enough to notice it, though...

  parent reply	other threads:[~2007-10-28  6:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-27  8:36 [PATCH 1/7] "git" returns 1; "git help" and "git help -a" return 0 Scott R Parish
2007-10-27  8:36 ` [PATCH 2/7] remove unused/unneeded "pattern" argument of list_commands Scott R Parish
2007-10-27  8:36   ` [PATCH 3/7] "current_exec_path" is a misleading name, use "argv_exec_path" Scott R Parish
2007-10-27  8:36     ` [PATCH 4/7] list_commands(): simplify code by using chdir() Scott R Parish
2007-10-27  8:36       ` [PATCH 5/7] use only the $PATH for exec'ing git commands Scott R Parish
2007-10-27  8:36         ` [PATCH 6/7] walk $PATH to generate list of commands for "help -a" Scott R Parish
2007-10-27  8:36           ` [PATCH 7/7] shell should call the new setup_path() to setup $PATH Scott R Parish
2007-10-28  6:18           ` [PATCH 6/7] walk $PATH to generate list of commands for "help -a" Junio C Hamano
2007-10-28  9:45             ` Scott Parish
2007-10-28 10:07               ` Junio C Hamano
2007-10-28 11:15                 ` Scott Parish
2007-10-28 11:18           ` [PATCH 6/7] include $PATH in generating " Scott R Parish
2007-10-28 11:32             ` Junio C Hamano
2007-10-28 14:39               ` Scott Parish
2007-10-28 14:44           ` Scott R Parish
2007-10-28 16:51             ` Johannes Schindelin
2007-10-29  2:44               ` Scott Parish
2007-10-29 11:30                 ` Johannes Schindelin
2007-10-29 11:45                   ` David Symonds
2007-10-29  3:30           ` Scott R Parish
2007-10-29 21:17             ` Junio C Hamano
2007-10-30  3:00               ` Scott Parish
2007-10-28  6:18         ` Junio C Hamano [this message]
2007-10-28  6:19           ` [PATCH 5/7] use only the $PATH for exec'ing git commands Adam Roben
2007-10-28 11:17         ` Scott R Parish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vlk9nzrrv.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=srp@srparish.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).