git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Nicolas Pitre <nico@cam.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Fredrik Kuivinen <frekui@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] Fix 'git commit -a' in a newly initialized repository
Date: Thu, 22 Feb 2007 21:03:02 -0800	[thread overview]
Message-ID: <7vlkipbh4p.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <alpine.LRH.0.82.0702221904210.27932@xanadu.home> (Nicolas Pitre's message of "Thu, 22 Feb 2007 19:06:41 -0500 (EST)")

Nicolas Pitre <nico@cam.org> writes:

> On Thu, 22 Feb 2007, Junio C Hamano wrote:
>
>> However, because ! test -f "$THIS_INDEX" is such a special case
>> (totally new check-in), we can afford to be verbose if we wanted
>> to, and offer tons of possibilities, say:
>> 
>> 	die 'nothing to commit.  You can use "git add file..."
>> to include individual files, or use "git add ." if you want to 
>> include all files in the current directory, for your first
>> commit.'
>> 
>> But if we want to say "for your first commit" in the message, we
>> should also be checking if HEAD commit really does not exist.
>
> Seems to me that the single line message avoids all those issues.

Yup.  Will apply Fredrik's original to 'maint'.

      reply	other threads:[~2007-02-23  5:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-22 20:28 [PATCH] Fix 'git commit -a' in a newly initialized repository Fredrik Kuivinen
2007-02-22 20:42 ` Johannes Schindelin
2007-02-22 20:54   ` Nicolas Pitre
2007-02-22 20:59     ` Johannes Schindelin
2007-02-22 21:09       ` Nicolas Pitre
2007-02-22 21:13         ` Johannes Schindelin
2007-02-22 21:36         ` Junio C Hamano
2007-02-23  0:06           ` Nicolas Pitre
2007-02-23  5:03             ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vlkipbh4p.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=frekui@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).