Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Subject: Re: [PATCH 6/6] gitweb: use blame --porcelain
Date: Thu, 05 Oct 2006 14:18:36 -0700	[thread overview]
Message-ID: <7vlknubgwj.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vwt7ebhe9.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Thu, 05 Oct 2006 14:07:58 -0700")

Side note.

This change does not give any more information (other than the
link to the corresponding line in the original version) than the
current gitweb in "next", but "blame --porcelain" returns richer
information than it used to be available, most notably the
summary line.  It might be interesting to enhance the title pop-up
mechanism to show them on mouse-over, but I was too lazy ;-).

I've considered making the commit-8 link to link not to the
commit page for the originating commit but to the corresponding
line in the blame page for it, but opted to take over the line
number link, which was serving far less useful purpose.  Your
keyboard has PgUp and PgDn to let you navigate within the same
blame output.

As I noted in the log message for [3/6], I suspect that the
curent implementation to show the original line number is
unnecessarily inefficient.  Improvement is much encouraged.
Again, I am too lazy to look into it right now.

  reply	other threads:[~2006-10-05 21:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-05 21:07 [PATCH 6/6] gitweb: use blame --porcelain Junio C Hamano
2006-10-05 21:18 ` Junio C Hamano [this message]
2006-10-05 21:48 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vlknubgwj.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox