From: Junio C Hamano <junkio@cox.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Add local time and timezone to git_print_authorship
Date: Tue, 29 Aug 2006 21:26:38 -0700 [thread overview]
Message-ID: <7vlkp6kfwh.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: ed142v$fbi$1@sea.gmane.org
Jakub Narebski <jnareb@gmail.com> writes:
> Junio C Hamano wrote:
>
>> (3) I'd like to eventually get rid of the abbreviated commit
>> object name from blame output, so the setting in gitweb.css
>> for table.blame td.age[012] (different colors and font
>> styles) is not appropriate for what I am shooting at.
>
> What do you want to replace it with? Link can be to "commit" or "commitdiff"
> view, but some marker for commit (perhaps 'git-name-rev --tags'?) is
> needed.
I was hoping I can get away with a narrow single column of solid
color that says nothing. 8 hexadecimal digits do not mean much
to humans and it is taking 8-column or so of screen real estate
that could otherwise be used to show the source lines instead.
I've tried doing that (just set $rev to a single space, and make
the "Commit" column narrower in sub blame2 {}). One drawback is
that while 8 hexadecimal digits do not mean anything they do
help to match lines that came from the same rev (i.e. "I do not
know what this 8fad7343 mean but this group of lines and that
group are tagged together with that same 8fad7343 so they must
come from the same revision").
next prev parent reply other threads:[~2006-08-30 4:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 12:48 [PATCH 0/5] gitweb: Additions to commitdiff view Jakub Narebski
2006-08-28 12:48 ` [PATCH 1/5] gitweb: Make git_print_log generic; git_print_simplified_log uses it Jakub Narebski
2006-08-28 12:48 ` [PATCH 2/5] gitweb: Do not remove signoff lines in git_print_simplified_log Jakub Narebski
2006-08-28 12:48 ` [PATCH 3/5] gitweb: Add author information to commitdiff view Jakub Narebski
2006-08-28 12:48 ` [PATCH 4/5] gitweb: git_print_log: signoff line is non-empty line Jakub Narebski
2006-08-28 12:48 ` [PATCH 5/5] gitweb: Add diff tree, with links to patches, to commitdiff view Jakub Narebski
2006-08-28 17:26 ` [PATCH 0/5] gitweb: Additions " Linus Torvalds
2006-08-28 21:17 ` [PATCH] gitweb: Add local time and timezone to git_print_authorship Jakub Narebski
2006-08-29 0:16 ` Junio C Hamano
2006-08-29 8:23 ` Jakub Narebski
2006-08-29 9:05 ` Junio C Hamano
2006-08-29 10:15 ` Jakub Narebski
2006-08-30 4:26 ` Junio C Hamano [this message]
2006-08-30 9:47 ` Jakub Narebski
2006-08-29 9:06 ` [PATCH] gitweb: split output routine of blame2 Junio C Hamano
2006-08-29 9:06 ` [PATCH] gitweb: show rev only on the first line of each group in blame Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlkp6kfwh.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).