From: Junio C Hamano <junkio@cox.net>
To: Eric Wong <normalperson@yhbt.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t1400-update-ref: set VISUAL=true as well as EDITOR=true
Date: Tue, 11 Jul 2006 02:15:34 -0700 [thread overview]
Message-ID: <7vlkr04i4p.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11526072802855-git-send-email-normalperson@yhbt.net> (Eric Wong's message of "Tue, 11 Jul 2006 01:41:20 -0700")
Eric Wong <normalperson@yhbt.net> writes:
> I have VISUAL set in my environment, and it caused git-commit to
> spawn my editor during the test.
I think it would be better to remove "EDITOR=: VISUAL=:"
settings from annotate-tests.sh, t1400-update-ref.sh and
t4013-diff-various.sh, and move that to test-lib.sh; there is no
point overriding them differently in each of these automated
tests.
next prev parent reply other threads:[~2006-07-11 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-11 8:41 [PATCH] t1400-update-ref: set VISUAL=true as well as EDITOR=true Eric Wong
2006-07-11 9:15 ` Junio C Hamano [this message]
2006-07-11 19:01 ` [PATCH] tests: Set EDITOR=: and VISUAL=: globally Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlkr04i4p.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).