From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Introduce Git.pm (v3) Date: Thu, 22 Jun 2006 16:18:10 -0700 Message-ID: <7vlkrohj9p.fsf@assigned-by-dhcp.cox.net> References: <20060622220201.19132.67536.stgit@machine.or.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: X-From: git-owner@vger.kernel.org Fri Jun 23 01:18:49 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FtYRh-0007dv-3l for gcvg-git@gmane.org; Fri, 23 Jun 2006 01:18:45 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030466AbWFVXSO (ORCPT ); Thu, 22 Jun 2006 19:18:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161457AbWFVXSN (ORCPT ); Thu, 22 Jun 2006 19:18:13 -0400 Received: from fed1rmmtao12.cox.net ([68.230.241.27]:27836 "EHLO fed1rmmtao12.cox.net") by vger.kernel.org with ESMTP id S1161446AbWFVXSM (ORCPT ); Thu, 22 Jun 2006 19:18:12 -0400 Received: from assigned-by-dhcp.cox.net ([68.4.9.127]) by fed1rmmtao12.cox.net (InterMail vM.6.01.06.01 201-2131-130-101-20060113) with ESMTP id <20060622231811.SXSK19057.fed1rmmtao12.cox.net@assigned-by-dhcp.cox.net>; Thu, 22 Jun 2006 19:18:11 -0400 To: Petr Baudis In-Reply-To: <20060622220201.19132.67536.stgit@machine.or.cz> (Petr Baudis's message of "Fri, 23 Jun 2006 00:02:01 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Petr Baudis writes: > * Added hash_object() and Git.xs providing the fast implementation > * Better error reporting > * Plenty of random minor stuff > > It's a good thing v2 didn't make it to the list since it contained a huge > file which turns out that can be autogenerated at the build time, so v3 > just changes that (and adds .gitignore file and makes some other minor > changes). > > I consider this patch "stable" now. Further enhancements will be posted > as patches on top of this. Eek. It does not compile for me -- maybe there is more dependencies that need to be listed in INSTALL file? make -C perl make[1]: Entering directory `/opt/git/git.git/perl' cc -c -I. -I.. -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION=\"0.01\" -DXS_VERSION=\"0.01\" -fPIC "-I/usr/lib/perl/5.8/CORE" -O2 -Wall -Wdeclaration-after-statement -g -DSHA1_HEADER='' Git.c Git.xs: In function 'XS_Git_xs_hash_object': Git.xs:27: warning: ISO C90 forbids mixed declarations and code Git.xs:44: warning: passing argument 1 of 'Perl_io_close' from incompatible pointer type Git.xs:44: warning: passing argument 2 of 'Perl_io_close' makes pointer from integer without a cast Git.xs:44: error: too few arguments to function 'Perl_io_close' make[1]: *** [Git.o] Error 1 make[1]: Leaving directory `/opt/git/git.git/perl' make: *** [all] Error 2