Re: [PATCH] git-daemon: --inetd implies --syslog

[Junio C Hamano <junkio@cox.net>]

exon@op5.se (Andreas Ericsson) writes:

> Otherwise nothing is logged anywhere, which is a Bad Thing.
>
> Signed-off-by: Andreas Ericsson <ae@op5.se>

Thanks; I am OK with what you are trying to do with this change,
except that:

 - I suspect closing stderr is still needed (the "workaround"
   was about inetd connection sending output to both fd 1 and 2
   to the client, which would corrupt the protocol conversation
   when exec'ed program writes anything to its standard error
   stream).

 - I would have preferred the removal of needless else as a
   separate cleanup patch (this is minor).

Peter, I am CC'ing this to you because I do not know how you run
the daemon on kernel.org machines -- I suspect you use --syslog
already and am hoping you are OK with this change.