From: Junio C Hamano <junkio@cox.net>
To: Frank Sorenson <frank@tuxrocks.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] git-repack-script: Add option to repack all objects.
Date: Mon, 29 Aug 2005 10:34:43 -0700 [thread overview]
Message-ID: <7vll2kbqa4.fsf_-_@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vvf1obsfc.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Mon, 29 Aug 2005 09:48:23 -0700")
This originally came from Frank Sorenson but with a bit of
rework to allow future enhancement to the command without
changing the external interface for removal part.
With the '-a' option, all objects in the current repository are
packed into a single pack. When the '-d' option is given at the
same time, existing packs that were made redundant by this round
of repacking are deleted.
Since we currently have only two repacking strategies, one '-a'
(everything into one) and the other not '-a' (incrementally pack
only the unpacked ones), '-d' is meaningful only used with '-a'
and removes all the existing packs before repacking for now.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
Junio C Hamano <junkio@cox.net> writes:
> I am not saying we should not remove old pack. I am saying that
> repacking, choosing which pack to remove and doing the actual
> removing should be kept as separate steps and in separate
> commands, perhaps the latter two as part of "git prune".
Frank, this is what I meant by the above. When we have pack
redundancy detection and removal in "git prune", probably we
would call it when '-d' is given instead of rolling our own
here. That is, "git repack [-a] -d" would be just a
shorthand to say "repack" without '-d' immediately followed
by "git prune --redundant-packs".
Pack optimization idea itself might turn out to be not worth
it, in which case this version would suffice. I don't know..
git-repack-script | 51 +++++++++++++++++++++++++++++++++++++++++++--------
1 files changed, 43 insertions(+), 8 deletions(-)
0c3d34bce4c44640a606e47c6346c400bc353604
diff --git a/git-repack-script b/git-repack-script
--- a/git-repack-script
+++ b/git-repack-script
@@ -5,28 +5,63 @@
. git-sh-setup-script || die "Not a git archive"
-no_update_info=
+no_update_info= all_into_one= remove_redundant=
while case "$#" in 0) break ;; esac
do
case "$1" in
-n) no_update_info=t ;;
+ -a) all_into_one=t ;;
+ -d) remove_redandant=t ;;
*) break ;;
esac
shift
done
rm -f .tmp-pack-*
-packname=$(git-rev-list --unpacked --objects $(git-rev-parse --all) |
- git-pack-objects --non-empty --incremental .tmp-pack) ||
+PACKDIR="$GIT_OBJECT_DIRECTORY/pack"
+
+# There will be more repacking strategies to come...
+case ",$all_into_one," in
+,,)
+ rev_list='--unpacked'
+ rev_parse='--all'
+ pack_objects='--incremental'
+ ;;
+,t,)
+ rev_list=
+ rev_parse='--all'
+ pack_objects=
+ # This part is a stop-gap until we have proper pack redundancy
+ # checker.
+ existing=`cd "$PACKDIR" && \
+ find . -type f \( -name '*.pack' -o -name '*.idx' \) -print`
+ ;;
+esac
+name=$(git-rev-list --objects $rev_list $(git-rev-parse $rev_parse) |
+ git-pack-objects --non-empty $pack_objects .tmp-pack) ||
exit 1
-if [ -z "$packname" ]; then
- echo Nothing new to pack
+if [ -z "$name" ]; then
+ echo Nothing new to pack.
exit 0
fi
+echo "Pack pack-$name created."
+
+mkdir -p "$PACKDIR" || exit
+
+mv .tmp-pack-$name.pack "$PACKDIR/pack-$name.pack" &&
+mv .tmp-pack-$name.idx "$PACKDIR/pack-$name.idx" ||
+exit
+
+if test "$remove_redandant" = t
+then
+ # We know $existing are all redandant only when
+ # all-into-one is used.
+ if test "$all_into_one" != '' && test "$existing" != ''
+ then
+ ( cd "$PACKDIR" && rm -f $existing )
+ fi
+fi
-mkdir -p "$GIT_OBJECT_DIRECTORY/pack" &&
-mv .tmp-pack-$packname.pack "$GIT_OBJECT_DIRECTORY/pack/pack-$packname.pack" &&
-mv .tmp-pack-$packname.idx "$GIT_OBJECT_DIRECTORY/pack/pack-$packname.idx" &&
case "$no_update_info" in
t) : ;;
*) git-update-server-info ;;
next prev parent reply other threads:[~2005-08-29 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-27 8:41 [PATCH] git-repack-script: Add option to repack all objects Frank Sorenson
2005-08-28 21:06 ` Junio C Hamano
2005-08-29 7:41 ` Frank Sorenson
2005-08-29 16:48 ` Junio C Hamano
2005-08-29 17:34 ` Junio C Hamano [this message]
2005-08-29 18:29 ` A Large Angry SCM
2005-08-29 18:44 ` Junio C Hamano
2005-08-29 18:57 ` A Large Angry SCM
2005-08-29 19:44 ` Junio C Hamano
2005-08-29 18:59 ` Frank Sorenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vll2kbqa4.fsf_-_@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=frank@tuxrocks.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).