From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Subject: [RFC] rename/rename conflicts: do they matter?
Date: Wed, 08 Jun 2005 10:21:43 -0700 [thread overview]
Message-ID: <7vll5k69y0.fsf@assigned-by-dhcp.cox.net> (raw)
I was reviewing git-merge-one-file-script, and started
thinking...
It currently has a logic that says if both branches deleted the
same file, instead of taking that as a concensus to remove it,
it refuses to merge the path. The error message states "This is a
potential rename conflict." as the rationale for doing so. It
is trying to be careful about one branch renaming the file to
something while the other renaming it to something else.
However, it happily deletes "deleted in one and unchanged in the
other". If we are so careful about "rename/rename conflicts", I
would think it would make more sense to be careful to consider
the possibility that one branch renamed this file, thereby
creating a copy at another path, while the other branch kept it
intact (the other side of this operation is "added in one"), but
we do not seem to bother worrying about it. If we try to be
anal about this, then even a simple "added in one" case could
trigger "copy/copy" conflict.
My current thinking is that the current logic for "both delete"
is too anal, and we should treat this case just like other
"concensus" cases; simply removing the path in this case would
be better.
next reply other threads:[~2005-06-08 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-08 17:21 Junio C Hamano [this message]
2005-06-09 0:34 ` [RFC] rename/rename conflicts: do they matter? Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vll5k69y0.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox