From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] remote-helpers: trivial cleanup
Date: Tue, 07 May 2013 22:43:53 -0700 [thread overview]
Message-ID: <7vmws6gh5y.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1367970315-5053-1-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Tue, 7 May 2013 18:45:15 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> The comment was copied from hg-fast-export, not used anymore.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> contrib/remote-helpers/git-remote-bzr | 1 -
> contrib/remote-helpers/git-remote-hg | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
> index c19ed0e..3604c7d 100755
> --- a/contrib/remote-helpers/git-remote-bzr
> +++ b/contrib/remote-helpers/git-remote-bzr
> @@ -323,7 +323,6 @@ def export_branch(branch, name):
> count += 1
> if (count % 100 == 0):
> print "progress revision %s (%d/%d)" % (revid, count, len(revs))
> - print "#############################################################"
>
> repo.unlock()
THe above no longer is relevant, I think, after a39769995050
(remote-bzr: improve progress reporting, 2013-04-30). I'll apply
only the hunk for remote-hg.
> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
> index 06920f2..96ad30d 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -453,7 +453,6 @@ def export_ref(repo, name, kind, head):
> count += 1
> if (count % 100 == 0):
> print "progress revision %d '%s' (%d/%d)" % (rev, name, count, len(revs))
> - print "#############################################################"
>
> # make sure the ref is updated
> print "reset %s/%s" % (prefix, ename)
prev parent reply other threads:[~2013-05-08 5:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 23:45 [PATCH] remote-helpers: trivial cleanup Felipe Contreras
2013-05-08 5:43 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmws6gh5y.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).