From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Garrett Cooper <yaneurabeya@gmail.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [RFC/PATCH 0/5] branch --set-upstream-to error-message improvements
Date: Tue, 02 Apr 2013 14:50:47 -0700 [thread overview]
Message-ID: <7vmwtga9fs.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130402190134.GA17784@sigill.intra.peff.net> (Jeff King's message of "Tue, 2 Apr 2013 15:01:34 -0400")
Jeff King <peff@peff.net> writes:
> On Tue, Apr 02, 2013 at 01:51:13PM -0400, Jeff King wrote:
>
>> Things slowly improve as people make suggestions. I think the thing that
>> might have helped here is better advice when "set-upstream-to" is
>> pointed to a ref that does not exist.
>>
>> Patches coming in a minute.
>
> Or 60 minutes. :)
>
> I'm not decided on whether the last patch is overkill or not (or even if
> it is not, whether it may end up confusing people who do not fit into
> one of the slots it suggests).
Yeah, I am uneasy about 5/5 for the same reason.
Also I feel a bit uneasy about 1/5 as well.
>> If the user requests to --set-upstream-to a branch that does
>> not exist, then either:
>>
>> 1. It was a typo.
>>
>> 2. They thought the branch should exist.
Could there be the third?
3. She planned to create a branch after setting the
configuration.
I think it is remote (no pun intended) possibility, and I may be
worried about people's existing workflow too much (as usual).
next prev parent reply other threads:[~2013-04-02 21:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 17:07 [BUG] inconsistent behavior with --set-upstream vs --set-upstream-to Garrett Cooper
2013-04-02 17:23 ` Jeff King
2013-04-02 17:30 ` Garrett Cooper
2013-04-02 17:51 ` Jeff King
2013-04-02 19:01 ` [RFC/PATCH 0/5] branch --set-upstream-to error-message improvements Jeff King
2013-04-02 19:02 ` [PATCH 1/5] t3200: test --set-upstream-to with bogus refs Jeff King
2013-04-02 19:03 ` [PATCH 2/5] branch: factor out "upstream is not a branch" error messages Jeff King
2013-04-02 19:36 ` Garrett Cooper
2013-04-02 19:36 ` Garrett Cooper
2013-04-02 19:04 ` [PATCH 3/5] branch: improve error message for missing --set-upstream-to ref Jeff King
2013-04-02 19:04 ` [PATCH 4/5] branch: mention start_name in set-upstream error messages Jeff King
2013-04-02 19:39 ` Garrett Cooper
2013-04-02 19:05 ` [PATCH 5/5] branch: give advice when tracking start-point is missing Jeff King
2013-04-02 21:50 ` Junio C Hamano [this message]
2013-04-02 19:08 ` [BUG] inconsistent behavior with --set-upstream vs --set-upstream-to Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmwtga9fs.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=yaneurabeya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).