From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, "Bo Yang" <struggleyb.nku@gmail.com>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
"Will Palmer" <wmpalmer@gmail.com>
Subject: Re: [PATCH v8 4/5] Implement line-history search (git log -L)
Date: Thu, 28 Feb 2013 14:23:05 -0800 [thread overview]
Message-ID: <7vmwuogjsm.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vbob4iaxh.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 28 Feb 2013 09:51:38 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Overall, I like this better than the "log --follow" hack; as the
> revision traversal is done without any pathspec when being "careful
> and slow" (aka -M), you do not suffer from the "just use a singleton
> pathspec globally regardless of what other history paths are being
> traversed" limitation of "log --follow".
>
> The patch series certainly is interesting.
Having said that, I notice that "careful and slow" is just "too slow
to be usable" even on a small tree like ours. Try running
$ git log -M -L:get_name:builtin/describe.c
and see how long you have to wait until you hit the first line of
output.
If some of the many NEEDSWORK in the code were fixed, this may
become "very slow but tolerable", but in the current shape, I doubt
it would be prudent to advance this to 'next' and further.
next prev parent reply other threads:[~2013-02-28 22:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 16:38 [PATCH v8 0/5] git log -L Thomas Rast
2013-02-28 16:38 ` [PATCH v8 1/5] Refactor parse_loc Thomas Rast
2013-02-28 17:16 ` Junio C Hamano
2013-02-28 19:24 ` Thomas Rast
2013-02-28 16:38 ` [PATCH v8 2/5] blame: introduce $ as "end of file" in -L syntax Thomas Rast
2013-02-28 17:18 ` Junio C Hamano
2013-03-12 22:34 ` Junio C Hamano
2013-03-13 7:52 ` Thomas Rast
2013-03-13 16:05 ` Junio C Hamano
2013-02-28 16:38 ` [PATCH v8 3/5] Export rewrite_parents() for 'log -L' Thomas Rast
2013-02-28 17:19 ` Junio C Hamano
2013-02-28 16:38 ` [PATCH v8 4/5] Implement line-history search (git log -L) Thomas Rast
2013-02-28 17:51 ` Junio C Hamano
2013-02-28 19:32 ` Thomas Rast
2013-02-28 20:37 ` Junio C Hamano
2013-02-28 21:41 ` Thomas Rast
2013-02-28 22:23 ` Junio C Hamano [this message]
2013-03-01 8:49 ` Thomas Rast
2013-03-01 14:59 ` Thomas Rast
2013-02-28 16:38 ` [PATCH v8 5/5] log -L: :pattern:file syntax to find by funcname Thomas Rast
2013-02-28 19:56 ` [PATCH v8 0/5] git log -L Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmwuogjsm.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=struggleyb.nku@gmail.com \
--cc=trast@student.ethz.ch \
--cc=wmpalmer@gmail.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).