git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v3] status: show the branch name if possible in in-progress info
Date: Tue, 05 Feb 2013 08:28:42 -0800	[thread overview]
Message-ID: <7vmwviu3lx.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CACsJy8D_kSrJYagxo1LWt=P8XKj9F9_yAwH3vzQWQOi+yvP8kg@mail.gmail.com> (Duy Nguyen's message of "Tue, 5 Feb 2013 19:20:51 +0700")

Duy Nguyen <pclouds@gmail.com> writes:

> On Tue, Feb 5, 2013 at 1:38 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Missing description.  Stealing from the link you sent:
>>
>>         The typical use-case is starting a rebase, do something else, come back
>>         the day after, run "git status" or make a new commit and wonder what
>>         in the world's going on. Which branch is being rebased is probably the
>>         most useful tidbit to help, but the target may help too.
>>
>>         Ideally, I would have loved to see "rebasing master on origin/master",
>>         but the target ref name is not stored during rebase, so this patch
>>         writes "rebasing master on a78c8c98b" as a half-measure to remind
>>         future users of that potential improvement.
>>
>>         Signed-off-by: <...>
>
> Looking good. Junio, do you need a new patch mail or can you just
> amend the commit message?

I'd like to see you either

 - send a reroll, making it clear it is a reroll, or
 - tell me to amend.

instead of asking which one I would prefer ;-)  One less message I
have to respond to that way.

"commit --amend" done.

      reply	other threads:[~2013-02-05 16:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29 12:10 [PATCH] status: show branch name if possible in in-progress info Nguyễn Thái Ngọc Duy
2013-01-29 12:31 ` Matthieu Moy
2013-01-29 12:56   ` Duy Nguyen
2013-01-29 13:13     ` Matthieu Moy
2013-01-29 16:18       ` Junio C Hamano
2013-01-29 14:58 ` [PATCH v2] status: show the " Nguyễn Thái Ngọc Duy
2013-01-29 18:44   ` Jonathan Nieder
2013-01-30  1:13     ` Duy Nguyen
2013-02-03  5:53   ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2013-02-05  6:38     ` Jonathan Nieder
2013-02-05 12:20       ` Duy Nguyen
2013-02-05 16:28         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmwviu3lx.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).